Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[thomasmonkman-filewatch] Add patch for fixing Unix version #35236

Merged
merged 6 commits into from
Nov 29, 2023
Merged

[thomasmonkman-filewatch] Add patch for fixing Unix version #35236

merged 6 commits into from
Nov 29, 2023

Conversation

Pravila00
Copy link
Contributor

@Pravila00 Pravila00 commented Nov 21, 2023 •
edited
Loading

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Pravila00
Copy link
Contributor Author

This patch comes from ThomasMonkman/filewatch#29, which trigger events on Unix as it does on Windows for having the same behaviour in both platforms.

@Pravila00 Pravila00 marked this pull request as ready for review November 21, 2023 17:21
Adela0814
Adela0814 suggested changes Nov 22, 2023
View reviewed changes
versions/t-/thomasmonkman-filewatch.json
"git-tree": "6dede6ba1ac505ea4bd64c60bf97edfe7b8d5647",
"version-date": "2023-01-16",
"port-version": 1
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restore the original git tree back.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've just restored the original git tree back, let me know if you need anything else from my side.

@Adela0814 Adela0814 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Nov 22, 2023
@Adela0814 Adela0814 marked this pull request as draft November 22, 2023 07:06
@Adela0814
Copy link
Contributor

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@Pravila00 Pravila00 marked this pull request as ready for review November 22, 2023 10:13
@Adela0814
Copy link
Contributor

This patch has been submitted to the upstream and has not responded for more than 2 years.

@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Nov 23, 2023
@vicroms vicroms merged commit 00d762b into microsoft:master Nov 29, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adela0814 Adela0814 Adela0814 approved these changes

Assignees

@Adela0814 Adela0814

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Pravila00 @Adela0814 @vicroms @pabloromicrosoft