Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After entering the font, a black color block will appear when rolling back #17928

Closed
qinshuze opened this issue Sep 16, 2024 · 2 comments
Closed
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-External For issues that are outside this codebase

Comments

@qinshuze
Copy link

Windows Terminal version

1.22.2362.0

Windows build number

10.0.19045.4894

Other Software

No response

Steps to reproduce

  1. Open Windows Terminal
    image

  2. Enter any character
    image

  3. Press the backspace key on the keyboard
    image

Expected Behavior

Do not show any color blocks

Actual Behavior

Black color blocks appeared

@qinshuze qinshuze added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 16, 2024
@lhecker
Copy link
Member

lhecker commented Sep 16, 2024

This is an intentional regression we introduced to make many other major improvements possible, including sixels. It was removed in #17666. The issue happens because Windows 10 ships with PowerShell 6 and PSReadLine 2.0.0-beta3, which contains a bug where the attributes are incorrect. The issue was fixed in this PR that ships with Windows 11: PowerShell/PSReadLine#1626

There's two ways to fix this issue:

@lhecker
Copy link
Member

lhecker commented Sep 16, 2024

I'll be closing this issue for now. If you think I made a mistake or if you have any questions, please feel free to ask here!

@lhecker lhecker closed this as not planned Won't fix, can't repro, duplicate, stale Sep 16, 2024
@lhecker lhecker added the Resolution-External For issues that are outside this codebase label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-External For issues that are outside this codebase
Projects
None yet
Development

No branches or pull requests

2 participants