Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows Terminal - Settings]: In dark mode, Luminosity ratio for 'Reset to inherited value' icon is '2.6:1', which is less than required '3:1'. #17902

Open
SaurabhNew opened this issue Sep 11, 2024 · 3 comments · May be fixed by #17912
Open

[Windows Terminal - Settings]: In dark mode, Luminosity ratio for 'Reset to inherited value' icon is '2.6:1', which is less than required '3:1'. #17902

SaurabhNew opened this issue Sep 11, 2024 · 3 comments · May be fixed by #17912
Labels
A11ySev2 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.23

Comments

@SaurabhNew
Copy link

Windows Terminal version

1.22.2362.0

Windows build number

27695.1000

Other Software

Test Environment:
OS: Windows 11 Version Dev (OS Build 27695.1000)
App: Windows Terminal Preview

Steps to reproduce

Prerequisites:
Settings> Personalization> Colors> Choose your Mode> Dark Mode.

Repro steps:

  1. Open the 'windows terminal' application.
  2. Apply dark mode by following the prerequisites.
  3. Now open 'Setting' and activate 'Startup' tab.
  4. Navigate to the 'Defaults' tab and activate it.
  5. Now navigate to the 'Appearance' button and activate it.
  6. Now navigate to any control like 'Line height' and change value.
  7. 'Reset to inherited value' button will appear.
  8. Open Accessibility Insights for windows and check contrast ratio of 'Reset to inherited value' icon.
  9. Observe the issue.

User experience:
Low vision users will find difficulty in tracking the control, if contrast ratio for the control's icon is less than '3:1' (Required).

WCAG Reference Link:
[MAS 4.3.1 – No Disruption of Accessibility Features.docx (sharepoint.com)](https://www.w3.org/WAI/WCAG22/Understanding/non-text-contrast)

Attachment:
MAS1.4.11 - In Dark mode, cca failed for 'Reset to inherited value' button..zip

Expected Behavior

In dark mode, Luminosity ratio for 'Reset to inherited value' icon should be greater than or equal to 3:1.

Actual Behavior

In dark mode, Luminosity ratio for 'Reset to inherited value' icon is '2.6:1', which is less than required '3:1'.

Note:
Same issue repro for all 'Reset to inherited value' button's icon throughout.
@SaurabhNew SaurabhNew added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 11, 2024
@carlos-zamora carlos-zamora added Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 11, 2024
@carlos-zamora
Copy link
Member

@SaurabhNew is there an associated severity rating for this issue?

@carlos-zamora carlos-zamora added this to the Terminal v1.23 milestone Sep 11, 2024
@carlos-zamora carlos-zamora linked a pull request Sep 11, 2024 that will close this issue
Draft
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Sep 11, 2024
@carlos-zamora
Copy link
Member

@SaurabhNew I'm making the change in PR #17912. I have a question though. The accent color is configurable by the user to be just about any color (I noticed you can't set it to white, thankfully). Because of that, the contrast can be wildly different. I've tested this out with various shades of the accent color (as described in these docs).

We want to maintain that the color used is the accent color, but going too light/dark removes that feeling of personalization from the app. Is there a suggested range of accent colors that are expected to be supported? Or any limitations on this space (like using the blue color you have it set to in your testing)?

@Priyanka-Chauhan123 Priyanka-Chauhan123 added HCL-E+D Accessibility tracking A11yWCAG Accessibility tracking HCL-WindowsTerminal Accessibility tracking A11ySev2 Accessibility tracking labels Sep 12, 2024
@SaurabhNew
Copy link
Author

SaurabhNew commented Sep 18, 2024 •
edited
Loading

@carlos-zamora, I referred the document that is mentioned above and observed that the HEX code of color used for '+1' will pass the contrast ratio of 3:1 in all high contrast modes.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A11ySev2 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.23
Development

Successfully merging a pull request may close this issue.

Improve color contrast of reset button in SUI microsoft/terminal
3 participants
@carlos-zamora @Priyanka-Chauhan123 @SaurabhNew