Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve color contrast of reset button in SUI #17912

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Improve color contrast of reset button in SUI #17912

wants to merge 2 commits into from

Conversation

carlos-zamora
Copy link
Member

Adds a theme resource for the color of the reset button in the settings UI.

Closes #17902

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. labels Sep 11, 2024
@carlos-zamora carlos-zamora mentioned this pull request Sep 11, 2024
Open
@carlos-zamora
Copy link
Member Author

This is in draft due to this question:

@SaurabhNew I'm making the change in PR #17912. I have a question though. The accent color is configurable by the user to be just about any color (I noticed you can't set it to white, thankfully). Because of that, the contrast can be wildly different. I've tested this out with various shades of the accent color (as described in these docs).

We want to maintain that the color used is the accent color, but going too light/dark removes that feeling of personalization from the app. Is there a suggested range of accent colors that are expected to be supported? Or any limitations on this space (like using the blue color you have it set to in your testing)?

DHowett
DHowett reviewed Sep 16, 2024
View reviewed changes
src/cascadia/TerminalSettingsEditor/SettingContainerStyle.xaml
@@ -73,6 +76,9 @@
ResourceKey="SystemColorWindowTextColorBrush" />
<StaticResource x:Key="SettingContainerMessageForeground"
ResourceKey="SystemColorWindowTextColorBrush" />

<StaticResource x:Key="SettingContainerResetButtonIconForeground"
ResourceKey="SystemAccentColorLight1" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know if this is correct in High Contrast - is there a more "contrasty" button content resource we should use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Area-Accessibility Issues related to accessibility Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
2 participants
@carlos-zamora @DHowett