Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restoring exited panes should not restart them #17883

Open
lhecker opened this issue Sep 9, 2024 · 1 comment
Open

Restoring exited panes should not restart them #17883

lhecker opened this issue Sep 9, 2024 · 1 comment
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.23

Comments

@lhecker
Copy link
Member

lhecker commented Sep 9, 2024

Description of the new feature/enhancement

  • Have session persistence enabled
  • Have a pane that has exited but wasn't closed, because the termination behavior is "never", etc.
  • Restart Windows Terminal
  • Suddenly all those tabs are running again

We should avoid restarting such tabs.

Proposed technical implementation details (optional)

The state.json should store whether a pane has exited. If it had then it should not restart it automatically.
@lhecker lhecker added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels Sep 9, 2024
@DHowett
Copy link
Member

DHowett commented Sep 11, 2024

I just had the same thought a couple days ago! We totally should.

@lhecker lhecker added this to the Terminal v1.23 milestone Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.23
Development

No branches or pull requests
2 participants
@DHowett @lhecker