Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search resets current position while new results arrive #17551

Closed
lhecker opened this issue Jul 11, 2024 · 2 comments
Closed

Search resets current position while new results arrive #17551

lhecker opened this issue Jul 11, 2024 · 2 comments
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@lhecker
Copy link
Member

lhecker commented Jul 11, 2024

Originally posted by @OAguinagalde here: 32fbb16:


On version 1.21.1772.0, whenever using some log reading tool such as logcat or similar, I still get the scroll being triggered on many situations that I wouldn't expect it to:

Situation: logcat or whatever constantly outputs stuff to the terminal. I search for something on the terminal.

  • Whenever a new occurrence of my search is output, it automatically jumps to the new one. I'd expect that if I'm on occurrence 10/10, and 2 new occurrences appear, my scrolls would be wherever I originally had it and the active search would stay at 10/12. Instead of that, the active search is automatically set to the latest one (12/12) and it jumps there.
  • Also, If I try to "follow" the log output as it is printed to the terminal, as soon as the active search result is out of the screen, it jumps back to it, even if there is no new occurrences of the search, so I'm forced to cancel the search (meaning that I lose the highlighting) to be able to follow the logs being printed.

Is this commit supposed to fix those situations? I'm unsure whether I got my versions wrong or whether these situations where not taken into account when working on it.


X3cU8gTVrTpZ5hFR.mp4
@lhecker lhecker added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Priority-3 A description (P3) labels Jul 11, 2024
@lhecker lhecker added this to the Terminal v1.22 milestone Jul 11, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 11, 2024
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 24, 2024
@DHowett
Copy link
Member

DHowett commented Aug 22, 2024

We should fix this at the same time as /dup #17301

Copy link
Contributor

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service microsoft-github-policy-service bot removed this from the Terminal v1.22 milestone Aug 22, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants