Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: VectorStore: Add Float64 support for Redis Vector Search #8846

Open
westey-m opened this issue Sep 17, 2024 · 0 comments
Open

.Net: VectorStore: Add Float64 support for Redis Vector Search #8846

westey-m opened this issue Sep 17, 2024 · 0 comments
Assignees
@westey-m
Labels
Ignite memory connector .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@westey-m
Copy link
Contributor

There is a gap in the Redis vector search support where we support Float64 for storage but not for Search so we need to close the gap by adding Float64 search support.
@westey-m westey-m added .NET Issue or Pull requests regarding .NET code memory connector Ignite labels Sep 17, 2024
@westey-m westey-m self-assigned this Sep 17, 2024
@westey-m westey-m removed the triage label Sep 17, 2024
@westey-m westey-m mentioned this issue Sep 17, 2024
Merged
4 tasks
westey-m added a commit that referenced this issue Sep 17, 2024
@westey-m
.Net: Add float64 support for redis vector search. (#8847)
434498a 
### Motivation and Context

Redis supports float64 for vector storage, and the Redis connectors were
supporting this as well, but not for search.

### Description

- Adding float64 support for Redis vector search with tests.
- Changed from suing name to fullname for outputting the vector type
name since name doesn't include the generic type.

#8846

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
@evchaki evchaki added the sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@westey-m westey-m

Labels
Ignite memory connector .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
Semantic Kernel
Status: Sprint: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@evchaki @markwallace-microsoft @westey-m