Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web] Rename WebNN EP MLOperandDescriptor's "dimensions" key to "shape" #22120

Closed
huningxin opened this issue Sep 18, 2024 · 1 comment · Fixed by #22121
Closed

[Web] Rename WebNN EP MLOperandDescriptor's "dimensions" key to "shape" #22120

huningxin opened this issue Sep 18, 2024 · 1 comment · Fixed by #22121
Labels
ep:WebNN WebNN execution provider platform:web issues related to ONNX Runtime web; typically submitted using template

Comments

@huningxin
Copy link

huningxin commented Sep 18, 2024 •
edited
Loading

Describe the issue

Align with spec and Chromium implementation change:

https://chromium-review.googlesource.com/c/chromium/src/+/5502631

webmachinelearning/webnn#676

/cc @Honry @fdwr

To reproduce

See the spec PR

Urgency

No response

ONNX Runtime Installation

Built from Source

ONNX Runtime Version or Commit ID

Latest

Execution Provider

WebNN EP
@huningxin huningxin added the platform:web issues related to ONNX Runtime web; typically submitted using template label Sep 18, 2024
@github-actions github-actions bot added the ep:WebNN WebNN execution provider label Sep 18, 2024
@fdwr
Copy link
Contributor

fdwr commented Sep 18, 2024

For now we can declare MLOperandDescs with both fields (shape is an alias of dimensions), so that we have some transitional overlap across Chromium versions without worrying about exactly matching. e.g.:

const someOperandDesc = {
    dataType: "float32",
    dimensions: listOfDimensions
    shape: listOfDimensions
}

This was referenced Sep 18, 2024
Merged
Open
fdwr pushed a commit that referenced this issue Sep 19, 2024
@Honry
[WebNN EP] Use both MLOperandDescriptor.dimensions and MLOperandDescr…
e33b08e 
…iptor.shape (#22121)

The spec renames MLOperandDescriptor.dimensions to
MLOperandDescriptor.shape, in order to support older Chromium versions,
we will keep both in WebNN EP for a while.

Fixed #22120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ep:WebNN WebNN execution provider platform:web issues related to ONNX Runtime web; typically submitted using template
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WebNN EP] Use both MLOperandDescriptor.dimensions and MLOperandDescriptor.shape Honry/onnxruntime
2 participants
@huningxin @fdwr