Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CoalescedLoRAExpertContainer to LoRAExpertContainer, e.g. remove LoraExpertContainer #96

Open
sordonia opened this issue Aug 20, 2024 · 0 comments

Comments

@sordonia
Copy link
Member

  • I think we should only rely on CoalescedLoRAExpertContainer, therefore we can just remove the other one
  • I think we can port to CoalescedLoRAExpertContainer the MoE logic in LoRAExpertContainer: e.g. if we route topk=2, we can only extract the unique indices of the experts in the batch -- if we have a lot of experts ~ 1000 -- this will be much less than the total number? this logic is already in LoRAExpertContainer, but not in CoalescedLoRAExpertContainer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant