Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic upstream sync may overwrite manually applied changes applied during sync #1345

Open
dagood opened this issue Oct 1, 2024 · 0 comments

Comments

@dagood
Copy link
Member

dagood commented Oct 1, 2024

There's a known race condition in the PR:

There's a ~1 minute window (observed in a recent run) where if a dev pushes a commit to the sync PR, it may still be overwritten by the bot.

For now, it seems like the value is very low:

  • The window is small.
  • If it does happen, the dev can simply push again (they are likely still set up to trivially run a force push).
  • Not much CI-running time is lost.
    • Losing CI results has been the larger sting for an overwrite. The commit itself was always recoverable.

The amount of investigation needed to implement a fix is probably not all that high, but the value is very low, so I'm filing this just to keep track of the known issue and potentially consider fixing it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant