Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDG (still) ICEs when consuming Standard Library Header Units #4957

Closed
CaseyCarter opened this issue Sep 14, 2024 · 1 comment
Closed

EDG (still) ICEs when consuming Standard Library Header Units #4957

CaseyCarter opened this issue Sep 14, 2024 · 1 comment
Labels
duplicate This issue or pull request already exists modules C++23 modules, C++20 header units test Related to test code

Comments

@CaseyCarter
Copy link
Member

P1502R1_standard_library_header_units is disabled for EDG with annotation TRANSITION, VSO-1232145 "EDG ICEs when consuming Standard Library Header Units":

# PM_CL="/BE" # TRANSITION, VSO-1232145 "EDG ICEs when consuming Standard Library Header Units"

VSO-1232145 was closed 2024-07-05. It's listed as "fixed" in #1694 but the test is nonetheless disabled. Enabling the test shows that it still ICEs.

#1621 does state that "EDG is currently investigating test failures. STL test coverage is not yet enabled." which could be intended as a blanket statement that we know there are problems and we are not tracking them individually.

We need to either reduce and report a new EDG issue or, if my "blanket statement" interpretation is correct, update the TRANSITION comment to point at GH-1621.

@CaseyCarter CaseyCarter added test Related to test code decision needed We need to choose something before working on this modules C++23 modules, C++20 header units labels Sep 14, 2024
@StephanTLavavej StephanTLavavej removed the decision needed We need to choose something before working on this label Sep 18, 2024
@StephanTLavavej
Copy link
Member

We talked about this at the weekly maintainer meeting. We know there are issues with EDG processing header units and named modules. Our understanding is that EDG is working on getting the header units test to compile, but (as with concepts earlier) analyzing/reducing/reporting individual issues would really help them.

We'll update the test workaround comment, but the real work that needs to happen here is investigating what blocking issues remain. We're going to resolve this as a duplicate of #1621 and fuse this into that issue.

@StephanTLavavej StephanTLavavej closed this as not planned Won't fix, can't repro, duplicate, stale Sep 18, 2024
@StephanTLavavej StephanTLavavej added the duplicate This issue or pull request already exists label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists modules C++23 modules, C++20 header units test Related to test code
Projects
None yet
Development

No branches or pull requests

2 participants