Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<queue>, <stack>: P3235R3 not implemented #4924

Open
CaseyCarter opened this issue Aug 30, 2024 · 1 comment
Open

<queue>, <stack>: P3235R3 not implemented #4924

CaseyCarter opened this issue Aug 30, 2024 · 1 comment
Labels
blocked on LWG Waiting for WG21 to tell us what to do bug Something isn't working format C++20/23 format

Comments

@CaseyCarter
Copy link
Member

CaseyCarter commented Aug 30, 2024 •
edited
Loading

We do not implement the required partial specializations of enable_nonlocking_formatter_optimization for queue, priority_queue, and stack. It's quite clearly a defect that container adaptors unconditionally enable the optimization regardless of whether the underlying containers or their elements enable the optimization.

Paper: WG21-P3235R3 std::print More Types Faster With Less Memory

This is LWG-4146.
@CaseyCarter CaseyCarter added the LWG issue needed A wording defect that should be submitted to LWG as a new issue label Aug 30, 2024
CaseyCarter added a commit to blackninja9939/STL that referenced this issue Aug 30, 2024
@CaseyCarter
Indicate partial implementation of P3235R3
bb52149 
I've filed microsoftGH-4924 to followup with LWG; we'll complete the implementation once the wording has been clarified.
@CaseyCarter CaseyCarter mentioned this issue Aug 30, 2024
Merged
@StephanTLavavej StephanTLavavej added the format C++20/23 format label Aug 30, 2024
@CaseyCarter

This comment was marked as outdated.

Sign in to view
@CaseyCarter CaseyCarter mentioned this issue Aug 31, 2024
Open
@CaseyCarter CaseyCarter added blocked on LWG Waiting for WG21 to tell us what to do bug Something isn't working and removed LWG issue needed A wording defect that should be submitted to LWG as a new issue labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked on LWG Waiting for WG21 to tell us what to do bug Something isn't working format C++20/23 format
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CaseyCarter @StephanTLavavej