From e6444a7d37832414fa43f3428c362b2b7d777364 Mon Sep 17 00:00:00 2001 From: Christopher Warrington Date: Fri, 6 Sep 2024 17:11:04 -0700 Subject: [PATCH 1/2] [EnvVar] Treat well-known debugging environment variables as lists The following environment variables are semi-colon lists, like "PATH" * _NT_SYMBOL_PATH * _NT_ALT_SYMBOL_PATH * _NT_SYMCACHE_PATH Treat them as lists in the Environment Variable editor. Windows Debugger paths are [documented as being semi-colon delimited][0]. The [`_NT_SYMCACHE_PATH` is used by WPA][1], and it also documented as being semi-colon delimited. [0]: https://learn.microsoft.com/en-us/windows/win32/debug/symbol-paths [1]: https://learn.microsoft.com/en-us/windows-hardware/test/wpt/loading-symbols --- .../EnvironmentVariablesUILib/Models/Variable.cs | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/modules/EnvironmentVariables/EnvironmentVariablesUILib/Models/Variable.cs b/src/modules/EnvironmentVariables/EnvironmentVariablesUILib/Models/Variable.cs index 0401384cd80..2cf33d60a67 100644 --- a/src/modules/EnvironmentVariables/EnvironmentVariablesUILib/Models/Variable.cs +++ b/src/modules/EnvironmentVariables/EnvironmentVariablesUILib/Models/Variable.cs @@ -63,7 +63,15 @@ public class ValuesListItem private bool IsList() { - List listVariables = new() { "PATH", "PATHEXT", "PSMODULEPATH" }; + List listVariables = new() + { + "_NT_ALT_SYMBOL_PATH", + "_NT_SYMBOL_PATH", + "_NT_SYMCACHE_PATH", + "PATH", + "PATHEXT", + "PSMODULEPATH", + }; foreach (var name in listVariables) { From d354183dec751a75ef63ac155ba54b3c0c4cf195 Mon Sep 17 00:00:00 2001 From: Christopher Warrington Date: Fri, 6 Sep 2024 18:14:01 -0700 Subject: [PATCH 2/2] [EnvVar] Add SYMCACHE to expected words list --- .github/actions/spell-check/expect.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/actions/spell-check/expect.txt b/.github/actions/spell-check/expect.txt index f5bc0156f8d..447f5f98116 100644 --- a/.github/actions/spell-check/expect.txt +++ b/.github/actions/spell-check/expect.txt @@ -1544,6 +1544,7 @@ SWC SWFO SWP SWRESTORE +SYMCACHE SYMED SYMOPT SYNCMFT