Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peek preview area flickers when jumping to next/previous file #34515

Open
rbtk1 opened this issue Aug 31, 2024 · 5 comments
Open

Peek preview area flickers when jumping to next/previous file #34515

rbtk1 opened this issue Aug 31, 2024 · 5 comments
Assignees
Labels
Issue-Bug Something isn't working Product-Peek Refers to Peek Powertoys Status-In progress This issue or work-item is under development

Comments

@rbtk1
Copy link

rbtk1 commented Aug 31, 2024

Microsoft PowerToys version

0.83.0

Installation method

WinGet

Running as admin

Yes

Area(s) with issue?

Peek

Steps to reproduce

Jumping from one file to the next using he arrow keys with Peek open, the preview area flickers every single time it previews the next file.
This might be considered a minor issue, but it looks quite bad and it reflect badly on the polish of the app.

✔️ Expected Behavior

No flickering when switching between previewed files with the arrow keys

❌ Actual Behavior

The preview area is cleared for a milisec before displaying the next file, making it flicker, especially if you quickly preview a bunch of files after one another.

Other Software

No response

@rbtk1 rbtk1 added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Aug 31, 2024
@daverayment
Copy link
Contributor

This is a bugbear of mine, too, so thank you very much for raising it as an issue! The underlying reason is related to the fact that the old previewer is removed and a new one created every time you navigate to a new file, which leads to the window background being shown briefly. It may be that keeping the old previewer around until the new one has finished loading the new file would be a viable solution, but there's some subtlety about how long to wait before showing that Peek has registered your input, so perhaps a new way of showing progress would be needed.

I'd like to look at this, but it's a medium-to-large complexity task affecting some fundamentals of how the different previewers are created and managed, so may take a while.

@ethanfangg
Copy link
Contributor

go for it @daverayment

@davidegiacometti davidegiacometti added Product-Peek Refers to Peek Powertoys Status-In progress This issue or work-item is under development and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Sep 16, 2024
@daverayment
Copy link
Contributor

@rbtk1
Can I ask you a couple of questions about this, please?

  1. Do you notice this with a specific type of file? I notice it most when navigating between image files, and so that's where I've started my work, but I didn't want to assume anything. I'd like to know if you've encountered this with other specific file types, too.
  2. When switching between files of different dimensions, the Peek window resizing itself could be seen as a 'flashing', too, where the new file's content pops into view after the window resizing happens. Do you think it would be preferable for the new content to load and then for the window resize to happen (which is the opposite of the current implementation), or is this not an issue for you?

Thank you!

@rbtk1
Copy link
Author

rbtk1 commented Sep 18, 2024

@daverayment
Thanks for taking a look at this, and good to hear others agree these smaller visual issues are important too 😁

For images its more noticable when flicking through very bright images since it will breifly flash dark (im using dark theme, so might be different reversed with the light OS theme), but i actually started this thread when i preview a whole bunch of folder and Peek unsupported files where it just shows the icon and the metadata, and got a bit annoyed the icon and text flashed every time selecting next/previous.
for images its especially annoying if comparing 2 similar images and go back and forth between them.

The window resizing im not sure about what i would prefer. As long as the image is not starting scaled down then scaled up afterwards along with the window frame and thereby would again appear to flicker, then i dont think i have a preference.

@daverayment
Copy link
Contributor

daverayment commented Sep 18, 2024

@rbtk1
It's a small, but certainly not a minor issue, so thanks again for raising it. It's not just a comfort issue, as some people are very susceptible to flashing lights.

Thanks so much for answering the questions; it's really going to help prioritise the work and give me an idea what's important to test for. I have a fix for the image previewer now, and it's much more pleasant to rapidly move through a folder now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Something isn't working Product-Peek Refers to Peek Powertoys Status-In progress This issue or work-item is under development
Projects
None yet
Development

No branches or pull requests

4 participants