Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BASIC source code preview #34210

Closed
ghylander opened this issue Aug 8, 2024 · 5 comments
Closed

Add support for BASIC source code preview #34210

ghylander opened this issue Aug 8, 2024 · 5 comments
Labels
Cost-Small Small work item - 0-8 hours of work Help Wanted We encourage anyone to jump in on these and submit a PR. Idea-Enhancement New feature or request on an existing product Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Product-File Explorer Power Toys that touch explorer like Preview Pane

Comments

@ghylander
Copy link

Description of the new feature / enhancement

Render BASIC source files in the preview pane

Scenario when this would be used?

Browsing BASIC source code files

Supporting information

No response

@ghylander ghylander added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Aug 8, 2024
@davidegiacometti davidegiacometti added Idea-Enhancement New feature or request on an existing product Product-File Explorer Power Toys that touch explorer like Preview Pane labels Aug 8, 2024
@crutkas
Copy link
Member

crutkas commented Aug 9, 2024

can you point me to an example of a file?

@crutkas
Copy link
Member

crutkas commented Aug 9, 2024

/needinfo

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Aug 9, 2024
@crutkas
Copy link
Member

crutkas commented Aug 9, 2024

if this is like a .bas file looks like this is possible as VS Code renders it correctly, should be just adding in the extension

image

@crutkas crutkas added Cost-Small Small work item - 0-8 hours of work Help Wanted We encourage anyone to jump in on these and submit a PR. labels Aug 9, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status-No recent activity no activity in the past 5 days when follow up's are needed label Aug 14, 2024
@ghylander
Copy link
Author

ghylander commented Aug 26, 2024

Sorry, I was on vacation, great to see that it was as easy as connecting with VS Code.

I see that it was not actually implemented. I could make it work myself and submit a pull request, where can I find info about connecting the file explorer preview to the appropriate VS Code extension?

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Status-No recent activity no activity in the past 5 days when follow up's are needed label Aug 26, 2024
@ghylander
Copy link
Author

Hi again, it's not clear to me whether support for BASIC source was added or not.
The bot marked this as completed and Done, but it seems to me like it was marked so because of the lack of activity.
The issue has also not been mentioned in a commit message or pull request.

Has support been added or does it still require implementation?
If the latter, as per my above comment I would be happy to contribute, but would need some indication or resources to begin with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cost-Small Small work item - 0-8 hours of work Help Wanted We encourage anyone to jump in on these and submit a PR. Idea-Enhancement New feature or request on an existing product Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Product-File Explorer Power Toys that touch explorer like Preview Pane
Projects
Status: ✅Done
Development

No branches or pull requests

3 participants