Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ScreenRuler] Multiple measurements for measuring tools #33494

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

drawbyperpetual
Copy link
Collaborator

Summary of the Pull Request

  • Adds support for multiple measurements for measuring tools.
  • Changes clipboard handling for Bounds tool to be in sync with measuring tools enhancements.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Demo:
screen_ruler_measurements_multiple

  • Holding the SHIFT key while releasing the primary mouse button keeps the current measurement displayed instead of hiding it.
  • Clipboard handling: all active measurements are copied to the clipboard when there are multiple measurements. Bounds tool also made to work this way.

Validation Steps Performed

  • Tested existing functionality as described here
  • Tested new functionality - multiple measurements / bounds by holding SHIFT key and releasing or hitting ESC. Some multiple measurements were made on multiple monitors.

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a quick test. I think the Bounds measure behaves a bit weirdly.
When you press shift and take measurements and then you release shift and try to take more measurements, those don't stick but stay in the same mode 🤔 Not sure this makes sense as user interaction.

@drawbyperpetual
Copy link
Collaborator Author

Gave it a quick test. I think the Bounds measure behaves a bit weirdly. When you press shift and take measurements and then you release shift and try to take more measurements, those don't stick but stay in the same mode 🤔 Not sure this makes sense as user interaction.

Other than clipboard handling, the Bounds tool hasn't been changed - only the measuring tools have, so the behavior you mention is an existing one. Having said that, I think it's actually quite logical - the heuristic is "Hold SHIFT to keep this box, otherwise forget it."

@GhostVaibhav
Copy link
Contributor

@jaimecbernardo @drawbyperpetual
Hello there. The functionality has changed since the repo has been updated quite a lot. Now, when we release the Shift key nothing happens and the bounding boxes still appear normally. E.g. -

multipleMeasureDemo

In the above demo, after the first 4 bounding boxes, I released my Shift key and pressed it again for the second set of 4s at the bottom of the screen. Everything was working fine.

@drawbyperpetual
Copy link
Collaborator Author

@GhostVaibhav : With the exception of clipboard behaviour, the intention of this change isn't to change the bounds tool - it's to make the measuring tools more like the bounds tool with respect to multiple measurements. Am I right to say from your comment that the measuring tool is working as you expect?

@GhostVaibhav
Copy link
Contributor

@drawbyperpetual Yes, it is working at par like the other utilities 👍🏻

@stefansjfw stefansjfw merged commit 9f491c8 into main Aug 20, 2024
14 checks passed
@crutkas crutkas deleted the dev/ani/screen-ruler-multiple-measurements branch September 7, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants