Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#27712] PowerToys New+ v0.1 #33136

Merged
merged 81 commits into from
Sep 19, 2024
Merged

Conversation

cgaarden
Copy link
Contributor

@cgaarden cgaarden commented May 29, 2024

Summary of the Pull Request

This PR contains the first very early version of New+ (#27712)

New+ is a new PowerToys for the File Explorer that enables users to create files and folders from a personalized set of templates.

Issue:
#27712

Spec:
https://1drv.ms/w/s!AgfnseFPEL1w2NklIIJb2hDgHkz6MQ?e=b8rSuL

This PR includes:
• Early version of New+
• New+ Windows 11 File Explorer support
• Dark and Light System Theme support
• Logging + Trace
• New+ GPO settings
• New+ Settings page
• New+ What's new page
• New+ example templaes
• New+ uninstall support

See also MicrosoftDocs/windows-dev-docs#5065

No new test projects yet

Don't think any changes are required

See also MicrosoftDocs/windows-dev-docs#5065

Detailed Description of the Pull Request / Additional comments

• Added System Theme to ThemeHelper.h/.cpp and renamed AppTheme enum to Theme

Validation Steps Performed

• Ran all unit tests except for UITests-FancyZones, UITests-FancyZonesEditor
• Removed all default settings
• Tested that defaults are same via Settings or just via invoking File Extension for the first time
• Removed new+ template folder
• Removed all items in new+ template folder
• Changed template folder location via settings 
• Changed hide extension via settings
• Changed dark and light system themes
• Basic test of Keyboard manager with different app theme
• Basic test of PowerRename with different app theme
• Toggling New+ via GPO settings
• Installing and uninstalling
• Uninstall only uninstalls example templates, does not uninstall user created templates

Made ThemeRegistryHelper protected
Removed New.wxs from installer
Restored logger_helper.h
Updated resources to have the right white space formatting
Replaced tabs with spaces
Added GPO info to GPO assets and fixed bug while testing GPO support
Added files for signing
@cgaarden cgaarden marked this pull request as draft May 29, 2024 03:46

This comment has been minimized.

Copy link
Collaborator

@htcfreek htcfreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution.

I made a small comment on the policy name.

src/gpo/assets/PowerToys.admx Outdated Show resolved Hide resolved
@cgaarden
Copy link
Contributor Author

@microsoft-github-policy-service agree

…ddress feedback from htcfreak

Update GPO setting name to reference NewPlus rather than just New - Address feedback from htcfreak

This comment has been minimized.

Copy link
Collaborator

@htcfreek htcfreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's the best to rename all places (docs, code, directory, installer) where the utility is called "New" to "NewPlus".

New can be read as new item and is confusing then.

src/common/ManagedCommon/ModuleType.cs Outdated Show resolved Hide resolved
src/common/GPOWrapper/GPOWrapper.cpp Outdated Show resolved Hide resolved
src/common/utils/gpo.h Outdated Show resolved Hide resolved
src/common/utils/gpo.h Outdated Show resolved Hide resolved
@Jay-o-Way Jay-o-Way added the Idea-New PowerToy Suggestion for a PowerToy label Jun 2, 2024
@htcfreek
Copy link
Collaborator

What is required to get this in? Waiting for it.

@jaimecbernardo
Copy link
Collaborator

Trying to get the branch to build again so we can re-review :)

@jaimecbernardo jaimecbernardo marked this pull request as ready for review September 19, 2024 10:33
@jaimecbernardo
Copy link
Collaborator

I've pushed a commit to fix spellcheck entries that seemed unneeded. a5403e6

@jaimecbernardo
Copy link
Collaborator

I've pushed a commit to fix an issue I've found while testing: if all templates were folders, the samples would be copied again. 2e07256

@jaimecbernardo
Copy link
Collaborator

I've pushed a commit so that Bug Report doesn't send the user templates inside the PowerToys settings folder, in case the user is still using the default location and might not want to link his teamplates. c69d94b

@jaimecbernardo
Copy link
Collaborator

I've pushed a commit to show a warning on Windows 10. bcfbac2
image

This comment has been minimized.

@jaimecbernardo
Copy link
Collaborator

I've added a infobox to inform users that Backup and Restore won't work with templates: 56610a5

image

@jaimecbernardo
Copy link
Collaborator

I've added a commit with more specific telemetry names: dda6cec

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well! And it's looking good to me!
Thank you for the contribution!

@jaimecbernardo jaimecbernardo merged commit 3f44ad1 into microsoft:main Sep 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Idea-New PowerToy Suggestion for a PowerToy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new file from a list of customizable templates straight from the folder context menu
8 participants