Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit conversion bug #31310

Closed
kwhur opened this issue Feb 6, 2024 · 10 comments
Closed

Unit conversion bug #31310

kwhur opened this issue Feb 6, 2024 · 10 comments
Labels
Issue-Bug Something isn't working Resolution-By Design Reported behavior reflects what the code is expected to do; it does not imply the design is good. Run-Plugin Things that relate with PowerToys Run's plugin interface

Comments

@kwhur
Copy link

kwhur commented Feb 6, 2024

Microsoft PowerToys version

0.78.0

Installation method

Microsoft Store

Running as admin

Yes

Area(s) with issue?

PowerToys Run

Steps to reproduce

PowerToys Run 에서 단위변한 시 잘못된 변관 값 표시
예)
%%1024Mb in Gb
image

✔️ Expected Behavior

1.000Gb

❌ Actual Behavior

1.024Gb

Other Software

No response

@kwhur kwhur added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Feb 6, 2024
@kwhur
Copy link
Author

kwhur commented Feb 6, 2024

Displaying incorrect conversion values in PowerToys Run when changing units

@LNKLEO
Copy link

LNKLEO commented Feb 6, 2024

no, that not a bug, but a correct answer.
you must have misunderstood Gib/Mib/etc. and Gb/Mb/etc.

image

@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Feb 6, 2024

Short story is: 10^2 = 1000 and 2^10 = 1024. A long, long time ago these were mixed up, meaning a kilobyte is/was 1024 bytes, while "kilo" should mean 1000. Nowadays, we invented the term kibibytes. Not even talking about the combination of the two types mentioned on storage devices...

It's actually bad practice of Microsoft to keep using the wrong unit, like, everywhere.
Also: MicrosoftDocs/microsoft-style-guide#392

@Jay-o-Way Jay-o-Way added Resolution-By Design Reported behavior reflects what the code is expected to do; it does not imply the design is good. Run-Plugin Things that relate with PowerToys Run's plugin interface and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Feb 6, 2024
@TheJoeFin
Copy link
Collaborator

Not sure if it was ever a mix up. Computer use base 2 not base 10. It is standard practice to refer to a kilobyte to be 1024 and not 1000.

@Jay-o-Way
Copy link
Collaborator

@TheJoeFin

  1. Just because it's done, doesn't mean it's right! Microsoft is downright wrong.
  2. How do you explain Mbps (Megabits, 1000000 bits)

The standards bodies have deprecated this usage of the megabyte in favor of a new set of binary prefixes, in which this quantity is designated by the unit mebibyte (MiB).

https://wikipedia.org/wiki/Megabyte

@TheJoeFin
Copy link
Collaborator

  1. I'm not arguing right vs wrong. It is semantics "mix up" vs "made different choices"
  2. I don't haha

@Jay-o-Way The initial screenshot show 1024 MB being reported as 1.024 GB. This would be correct to you right?

@Jay-o-Way
Copy link
Collaborator

Just a short rant against Microsoft, haha. Conclusion for this issue is valid: non-issue.

@kwhur
Copy link
Author

kwhur commented Feb 6, 2024

It's been over 20 years since the standards were established... I didn't know because I've only been using Windows OS. Thanks for letting me know

@Raf-UJ
Copy link

Raf-UJ commented Jul 25, 2024

I never realised I am duplicating.. sorry!
I think #33026 should be merged - is that a thing for issues?

@Raf-UJ
Copy link

Raf-UJ commented Jul 25, 2024

Since PowerToys is uniquely Microsoft related product I would love to hear your thoughts on potentially "fixing the historical issue" and provide accurate results for both each time regardless of the query?
Mentioning both MB and MiB each will slowly educate more and more users "as a byproduct".
Maybe even a button pop-up?
I wasn't fully aware how bad it is until I had to make fresh partition inside the windows environment.

  • please provide new partition size in MB
    me: 500000 MB > Next
  • WHAT DO YOU MEAN 500000MB PARTITION IS ONLY 465.66GB?! 😡
  • ugh, okay.. I know! PowerToys will surely give me an answer on how to make 500GB partition!
  • me: [Alt+Space] > [ %% 500GB in MB ] > [Enter]
    PowerToys: [ 500000 MB ]
  • nope...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Something isn't working Resolution-By Design Reported behavior reflects what the code is expected to do; it does not imply the design is good. Run-Plugin Things that relate with PowerToys Run's plugin interface
Projects
None yet
Development

No branches or pull requests

5 participants