Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerToys Run: Adding Clear Functionality For Older Files/Directories #28996

Open
RadhiRasho opened this issue Oct 4, 2023 · 9 comments
Open
Labels
Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Product-PowerToys Run Improved app launch PT Run (Win+R) Window Run-Results (Indexer) Issue with file search in PowerToys Run

Comments

@RadhiRasho
Copy link

Description of the new feature / enhancement

I use VS Code a lot and switching/opening directories where my projects are has been made so much easier due to PowerToys Run.

One thing I find lacking is the inability to clear out older/non-existent files/directories. This happens a lot especially when working with stuff like older project that were delete.

What I'm requesting is a way to clear out history of sorts, or individually get rid of files and directories that no longer exist.

image

In the image above, you see a bunch of folder/workspaces (I tend to work a lot with Development Containers, hence the extra (Dev Container) bit there)

Except none of those exist and yet they are still in the searchable list/history.

Scenario when this would be used?

Say I created a folder, name it FolderA, then I go to that folder and right click and open with vscode, that folder should now be in history/list of available options via the vs code plugin { FolderA, so I'm easily able to access it.

Created FolderA
image

Opened FolderA using Open With VS Code:
image

Used {FolderA to open it using PowerToy Run:
image

Now, Say I then decide FolderA is a terrible name, and that it shouldn't exist anymore, so I delete it completely, even from the trash bin.
image

Sense the folder no longer exists, I shouldn't see it in the list of results anymore, right? Wrong, it still shows up, only it leads to nowhere now:

image

Supporting information

No response

@RadhiRasho RadhiRasho added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Oct 4, 2023
@TheJoeFin TheJoeFin added Product-PowerToys Run Improved app launch PT Run (Win+R) Window Run-Results (Indexer) Issue with file search in PowerToys Run labels Oct 16, 2023
@RadhiRasho
Copy link
Author

RadhiRasho commented Dec 9, 2023

I've also noticed that Dev Container directories seem to shows a random Id sequence on all containers:
image

unsure whether adding this here or I should create a new issues.

this issue started occurring around version 0.72

EDIT: Moved to here: #32275

@kjohnsen
Copy link

Also, besides removing nonexistent workspaces, a related useful feature would be to sort workspaces with the same name so the most recently opened ones are on top. Having opened the same repo on multiple WSL distros, I find myself having to go to the bottom every time to get to Ubuntu-22, even though it's the main one I use

@htcfreek
Copy link
Collaborator

htcfreek commented Apr 4, 2024

@RadhiRasho
Is this issue still existing? Thought someone implemented a clean-up feature in one if the last releases (#30488). Can you please double check.

And if I understand correctly there are two issues:

  1. Clean up of inaccessible workspaces.
  2. The random id of dev containers.

If yes please split the issue into two separate ones that we can track the issues and work better.

@RadhiRasho
Copy link
Author

@htcfreek
It looks like the issue with non-existent directories has been cleaned up on the windows local disk side of things. Sorry I was not aware of that.

However the issue seems to persist when it comes to CodeSpaces, SSH-Remotes, and Development Containers (which I use often) as I have a list of non-existent ones still being displayed here:

image

Anything within the workspaces "Work" and Rando has been deleted, but is still being displayed.

Now that I've taken a look at issue #30488 I notice that it's specifically checking for WSL and Local and is ignoring the rest of the possible Remote workspaces. I could attempt to fix that issue if that's alright?

As for the issue with the Random ID of dev containers, I believe that is brought about due to the extra information bit, which I was thinking of maybe adding a Setting specifically for the VSCode Plugin that would either hide or show that detail (sense it's extra/unnecessary info).

I can move the Random ID one out to a different issue and edit my comment to point it there.

Hopefully this clarifies things

@htcfreek
Copy link
Collaborator

htcfreek commented Apr 5, 2024

@RadhiRasho
That sounds good. Pleas split the issue.

If you then like to work on one of them feel free to open a PR. If you have any further questions don't hesitate to ask for help.

@RadhiRasho
Copy link
Author

@htcfreek
Thank you, I'll proceed once I've got some time

@RadhiRasho
Copy link
Author

@htcfreek this is the new issue for the Random Id Sequence: #32275

Should I edit my comment on the Contribution discussion to work on that as well?

@htcfreek
Copy link
Collaborator

htcfreek commented Apr 5, 2024

@htcfreek this is the new issue for the Random Id Sequence: #32275

Should I edit my comment on the Contribution discussion to work on that as well?

@RadhiRasho
Should I assign both issues to you?

@RadhiRasho
Copy link
Author

@htcfreek I'd like to tackle the Random Id issue just to get my feet wet, after that I can work on the results issue

if by the time I'm done the result issue isn't taken I can take a look at that as well, sound good?

ps. this is my first OS project contribution so I'd like to take my time and learn a bit, if that's alright

@htcfreek htcfreek assigned RadhiRasho and unassigned RadhiRasho Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Product-PowerToys Run Improved app launch PT Run (Win+R) Window Run-Results (Indexer) Issue with file search in PowerToys Run
Projects
None yet
Development

No branches or pull requests

4 participants