Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Reasoning for Image Codeunit being limited to 5MB? #1970

Open
1 task done
mjmatthiesen opened this issue Sep 5, 2024 · 5 comments · May be fixed by #2112
Open
1 task done

[Bug]: Reasoning for Image Codeunit being limited to 5MB? #1970

mjmatthiesen opened this issue Sep 5, 2024 · 5 comments · May be fixed by #2112
Assignees
Labels
Approved The issue is approved Bug Something isn't working Integration GitHub request for Integration area

Comments

@mjmatthiesen
Copy link

mjmatthiesen commented Sep 5, 2024

Describe the issue

Originally started here.

The following limit is implemented.

This prevents processing larger images that may need to be cropped or altered in some fashion. This means we now have to make a request to an external service, process the return, etc., greatly increasing overhead and generally being slower, "locking" BC for more time.

Expected behavior

Have the limit be configurable, removed, or higher.

Steps to reproduce

pass in image that is larger than 5mb and get hit with error

Additional context

typically we process labels of some sort from an external service, e.g. ucc labels, and some services will return all images in a single image we then need to split and process to store and print correctly. Because of this limit, we are unable to use the built in BC tools and instead have to rely on external services.

I will provide a fix for a bug

  • I will provide a fix for a bug

Additional note

There may be a legitimate reason for the 5MB limit. This is more a hope that it can be changed in the future.

@mjmatthiesen mjmatthiesen added the Bug Something isn't working label Sep 5, 2024
@JesperSchulz
Copy link
Contributor

Asked internally if anyone remembers where that limit came from. Stay tuned!

@JesperSchulz JesperSchulz added the Approved The issue is approved label Sep 16, 2024
@JesperSchulz
Copy link
Contributor

No one remembers and I cannot find any reasoning. Hence approving issue.

@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Sep 16, 2024
@mjmatthiesen
Copy link
Author

No one remembers and I cannot find any reasoning. Hence approving issue.

Just want to clarify one thing: Does Microsoft still want a limit, or is no limit acceptable? I have a limit of 50MB in mind, but since I don't know the actual backend implication, if none is possible that would be "future proof" for us.

@JesperSchulz
Copy link
Contributor

No one remembers and I cannot find any reasoning. Hence approving issue.

Just want to clarify one thing: Does Microsoft still want a limit, or is no limit acceptable? I have a limit of 50MB in mind, but since I don't know the actual backend implication, if none is possible that would be "future proof" for us.

A limit is preferable. Uploading an image of several GB can derail the production system. 50MB sounds reasonable.

@mjmatthiesen
Copy link
Author

A limit is preferable. Uploading an image of several GB can derail the production system. 50MB sounds reasonable.

I'm too much of an idealist and assume people will play nice. Good point. I am out next week but will issue a PR when I come back. Thanks!

mjmatthiesen pushed a commit to mjmatthiesen/BCApps that referenced this issue Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved The issue is approved Bug Something isn't working Integration GitHub request for Integration area
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants