From 3172f722838c70882fbe58c1835041f5880bf05a Mon Sep 17 00:00:00 2001 From: bcbuild-github-agent <137281497+bcbuild-github-agent@users.noreply.github.com> Date: Wed, 18 Sep 2024 09:33:41 -0700 Subject: [PATCH 1/5] [main] Update AL-Go System Files from microsoft/AL-Go-PTE@preview - ff5817559912b8a13b51c09368f01a623acd2082 (#2059) Fixes [AB#420000](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/420000) Co-authored-by: bcbuild-github-agent --- .../.AL-Go/cloudDevEnv.ps1 | 101 +++++++++++ .../.AL-Go/localDevEnv.ps1 | 158 ++++++++++++++++++ 2 files changed, 259 insertions(+) create mode 100644 build/projects/System Application Tests (No Isolation)/.AL-Go/cloudDevEnv.ps1 create mode 100644 build/projects/System Application Tests (No Isolation)/.AL-Go/localDevEnv.ps1 diff --git a/build/projects/System Application Tests (No Isolation)/.AL-Go/cloudDevEnv.ps1 b/build/projects/System Application Tests (No Isolation)/.AL-Go/cloudDevEnv.ps1 new file mode 100644 index 0000000000..a720f24f19 --- /dev/null +++ b/build/projects/System Application Tests (No Isolation)/.AL-Go/cloudDevEnv.ps1 @@ -0,0 +1,101 @@ +# +# Script for creating cloud development environment +# Please do not modify this script as it will be auto-updated from the AL-Go Template +# Recommended approach is to use as is or add a script (freddyk-devenv.ps1), which calls this script with the user specific parameters +# +Param( + [string] $environmentName = "", + [bool] $reuseExistingEnvironment, + [switch] $fromVSCode, + [switch] $clean +) + +$errorActionPreference = "Stop"; $ProgressPreference = "SilentlyContinue"; Set-StrictMode -Version 2.0 + +function DownloadHelperFile { + param( + [string] $url, + [string] $folder + ) + + $prevProgressPreference = $ProgressPreference; $ProgressPreference = 'SilentlyContinue' + $name = [System.IO.Path]::GetFileName($url) + Write-Host "Downloading $name from $url" + $path = Join-Path $folder $name + Invoke-WebRequest -UseBasicParsing -uri $url -OutFile $path + $ProgressPreference = $prevProgressPreference + return $path +} + +try { +Clear-Host +Write-Host +Write-Host -ForegroundColor Yellow @' + _____ _ _ _____ ______ + / ____| | | | | __ \ | ____| + | | | | ___ _ _ __| | | | | | _____ __ |__ _ ____ __ + | | | |/ _ \| | | |/ _` | | | | |/ _ \ \ / / __| | '_ \ \ / / + | |____| | (_) | |_| | (_| | | |__| | __/\ V /| |____| | | \ V / + \_____|_|\___/ \__,_|\__,_| |_____/ \___| \_/ |______|_| |_|\_/ + +'@ + +$tmpFolder = Join-Path ([System.IO.Path]::GetTempPath()) "$([Guid]::NewGuid().ToString())" +New-Item -Path $tmpFolder -ItemType Directory -Force | Out-Null +$GitHubHelperPath = DownloadHelperFile -url 'https://raw.githubusercontent.com/microsoft/AL-Go/a2a51be438318a7e355fa9044815cf7890ffed1a/Actions/Github-Helper.psm1' -folder $tmpFolder +$ALGoHelperPath = DownloadHelperFile -url 'https://raw.githubusercontent.com/microsoft/AL-Go/a2a51be438318a7e355fa9044815cf7890ffed1a/Actions/AL-Go-Helper.ps1' -folder $tmpFolder +DownloadHelperFile -url 'https://raw.githubusercontent.com/microsoft/AL-Go/a2a51be438318a7e355fa9044815cf7890ffed1a/Actions/Packages.json' -folder $tmpFolder | Out-Null + +Import-Module $GitHubHelperPath +. $ALGoHelperPath -local + +$baseFolder = GetBaseFolder -folder $PSScriptRoot +$project = GetProject -baseFolder $baseFolder -projectALGoFolder $PSScriptRoot + +Write-Host @' + +This script will create a cloud based development environment (Business Central SaaS Sandbox) for your project. +All apps and test apps will be compiled and published to the environment in the development scope. +The script will also modify launch.json to have a "Cloud Sandbox ()" configuration point to your environment. + +'@ + +if (Test-Path (Join-Path $PSScriptRoot "NewBcContainer.ps1")) { + Write-Host -ForegroundColor Red "WARNING: The project has a NewBcContainer override defined. Typically, this means that you cannot run a cloud development environment" +} + +Write-Host + +if (-not $environmentName) { + $environmentName = Enter-Value ` + -title "Environment name" ` + -question "Please enter the name of the environment to create" ` + -default "$($env:USERNAME)-sandbox" ` + -trimCharacters @('"',"'",' ') +} + +if ($PSBoundParameters.Keys -notcontains 'reuseExistingEnvironment') { + $reuseExistingEnvironment = (Select-Value ` + -title "What if the environment already exists?" ` + -options @{ "Yes" = "Reuse existing environment"; "No" = "Recreate environment" } ` + -question "Select behavior" ` + -default "No") -eq "Yes" +} + +CreateDevEnv ` + -kind cloud ` + -caller local ` + -environmentName $environmentName ` + -reuseExistingEnvironment:$reuseExistingEnvironment ` + -baseFolder $baseFolder ` + -project $project ` + -clean:$clean +} +catch { + Write-Host -ForegroundColor Red "Error: $($_.Exception.Message)`nStacktrace: $($_.scriptStackTrace)" +} +finally { + if ($fromVSCode) { + Read-Host "Press ENTER to close this window" + } +} diff --git a/build/projects/System Application Tests (No Isolation)/.AL-Go/localDevEnv.ps1 b/build/projects/System Application Tests (No Isolation)/.AL-Go/localDevEnv.ps1 new file mode 100644 index 0000000000..fb49fd4041 --- /dev/null +++ b/build/projects/System Application Tests (No Isolation)/.AL-Go/localDevEnv.ps1 @@ -0,0 +1,158 @@ +# +# Script for creating local development environment +# Please do not modify this script as it will be auto-updated from the AL-Go Template +# Recommended approach is to use as is or add a script (freddyk-devenv.ps1), which calls this script with the user specific parameters +# +Param( + [string] $containerName = "", + [ValidateSet("UserPassword", "Windows")] + [string] $auth = "", + [pscredential] $credential = $null, + [string] $licenseFileUrl = "", + [switch] $fromVSCode, + [switch] $accept_insiderEula, + [switch] $clean +) + +$errorActionPreference = "Stop"; $ProgressPreference = "SilentlyContinue"; Set-StrictMode -Version 2.0 + +function DownloadHelperFile { + param( + [string] $url, + [string] $folder + ) + + $prevProgressPreference = $ProgressPreference; $ProgressPreference = 'SilentlyContinue' + $name = [System.IO.Path]::GetFileName($url) + Write-Host "Downloading $name from $url" + $path = Join-Path $folder $name + Invoke-WebRequest -UseBasicParsing -uri $url -OutFile $path + $ProgressPreference = $prevProgressPreference + return $path +} + +try { +Clear-Host +Write-Host +Write-Host -ForegroundColor Yellow @' + _ _ _____ ______ + | | | | | __ \ | ____| + | | ___ ___ __ _| | | | | | _____ __ |__ _ ____ __ + | | / _ \ / __/ _` | | | | | |/ _ \ \ / / __| | '_ \ \ / / + | |____ (_) | (__ (_| | | | |__| | __/\ V /| |____| | | \ V / + |______\___/ \___\__,_|_| |_____/ \___| \_/ |______|_| |_|\_/ + +'@ + +$tmpFolder = Join-Path ([System.IO.Path]::GetTempPath()) "$([Guid]::NewGuid().ToString())" +New-Item -Path $tmpFolder -ItemType Directory -Force | Out-Null +$GitHubHelperPath = DownloadHelperFile -url 'https://raw.githubusercontent.com/microsoft/AL-Go/a2a51be438318a7e355fa9044815cf7890ffed1a/Actions/Github-Helper.psm1' -folder $tmpFolder +$ALGoHelperPath = DownloadHelperFile -url 'https://raw.githubusercontent.com/microsoft/AL-Go/a2a51be438318a7e355fa9044815cf7890ffed1a/Actions/AL-Go-Helper.ps1' -folder $tmpFolder +DownloadHelperFile -url 'https://raw.githubusercontent.com/microsoft/AL-Go/a2a51be438318a7e355fa9044815cf7890ffed1a/Actions/Packages.json' -folder $tmpFolder | Out-Null + +Import-Module $GitHubHelperPath +. $ALGoHelperPath -local + +$baseFolder = GetBaseFolder -folder $PSScriptRoot +$project = GetProject -baseFolder $baseFolder -projectALGoFolder $PSScriptRoot + +Write-Host @' + +This script will create a docker based local development environment for your project. + +NOTE: You need to have Docker installed, configured and be able to create Business Central containers for this to work. +If this fails, you can setup a cloud based development environment by running cloudDevEnv.ps1 + +All apps and test apps will be compiled and published to the environment in the development scope. +The script will also modify launch.json to have a Local Sandbox configuration point to your environment. + +'@ + +$settings = ReadSettings -baseFolder $baseFolder -project $project -userName $env:USERNAME -workflowName 'localDevEnv' + +Write-Host "Checking System Requirements" +$dockerProcess = (Get-Process "dockerd" -ErrorAction Ignore) +if (!($dockerProcess)) { + Write-Host -ForegroundColor Red "Dockerd process not found. Docker might not be started, not installed or not running Windows Containers." +} +if ($settings.keyVaultName) { + if (-not (Get-Module -ListAvailable -Name 'Az.KeyVault')) { + Write-Host -ForegroundColor Red "A keyvault name is defined in Settings, you need to have the Az.KeyVault PowerShell module installed (use Install-Module az) or you can set the keyVaultName to an empty string in the user settings file ($($ENV:UserName).settings.json)." + } +} + +Write-Host + +if (-not $containerName) { + $containerName = Enter-Value ` + -title "Container name" ` + -question "Please enter the name of the container to create" ` + -default "bcserver" ` + -trimCharacters @('"',"'",' ') +} + +if (-not $auth) { + $auth = Select-Value ` + -title "Authentication mechanism for container" ` + -options @{ "Windows" = "Windows Authentication"; "UserPassword" = "Username/Password authentication" } ` + -question "Select authentication mechanism for container" ` + -default "UserPassword" +} + +if (-not $credential) { + if ($auth -eq "Windows") { + $credential = Get-Credential -Message "Please enter your Windows Credentials" -UserName $env:USERNAME + $CurrentDomain = "LDAP://" + ([ADSI]"").distinguishedName + $domain = New-Object System.DirectoryServices.DirectoryEntry($CurrentDomain,$credential.UserName,$credential.GetNetworkCredential().password) + if ($null -eq $domain.name) { + Write-Host -ForegroundColor Red "Unable to verify your Windows Credentials, you might not be able to authenticate to your container" + } + } + else { + $credential = Get-Credential -Message "Please enter username and password for your container" -UserName "admin" + } +} + +if (-not $licenseFileUrl) { + if ($settings.type -eq "AppSource App") { + $description = "When developing AppSource Apps for Business Central versions prior to 22, your local development environment needs the developer licensefile with permissions to your AppSource app object IDs" + $default = "none" + } + else { + $description = "When developing PTEs, you can optionally specify a developer licensefile with permissions to object IDs of your dependant apps" + $default = "none" + } + + $licenseFileUrl = Enter-Value ` + -title "LicenseFileUrl" ` + -description $description ` + -question "Local path or a secure download URL to license file " ` + -default $default ` + -doNotConvertToLower ` + -trimCharacters @('"',"'",' ') +} + +if ($licenseFileUrl -eq "none") { + $licenseFileUrl = "" +} + +CreateDevEnv ` + -kind local ` + -caller local ` + -containerName $containerName ` + -baseFolder $baseFolder ` + -project $project ` + -auth $auth ` + -credential $credential ` + -licenseFileUrl $licenseFileUrl ` + -accept_insiderEula:$accept_insiderEula ` + -clean:$clean +} +catch { + Write-Host -ForegroundColor Red "Error: $($_.Exception.Message)`nStacktrace: $($_.scriptStackTrace)" +} +finally { + if ($fromVSCode) { + Read-Host "Press ENTER to close this window" + } +} From b492864af1f571b3e0430e27c11b35036950ba0b Mon Sep 17 00:00:00 2001 From: bcbuild-github-agent <137281497+bcbuild-github-agent@users.noreply.github.com> Date: Thu, 19 Sep 2024 01:26:25 -0700 Subject: [PATCH 2/5] [main] Update BCArtifact version. New value: 26.0.24375.0 (#2062) This PR contains the following changes: - Update BCArtifact version. New value: 26.0.24375.0 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: mazhelez --- .github/AL-Go-Settings.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/AL-Go-Settings.json b/.github/AL-Go-Settings.json index 4a3585b774..7dddb24273 100644 --- a/.github/AL-Go-Settings.json +++ b/.github/AL-Go-Settings.json @@ -5,7 +5,7 @@ "runs-on": "windows-latest", "cacheImageName": "", "UsePsSession": false, - "artifact": "https://bcinsider-fvh2ekdjecfjd6gk.b02.azurefd.net/sandbox/26.0.24318.0/base", + "artifact": "https://bcinsider-fvh2ekdjecfjd6gk.b02.azurefd.net/sandbox/26.0.24375.0/base", "country": "base", "useProjectDependencies": true, "repoVersion": "26.0", From bc59d2aa7fb5a6faeb8d811094d5902488543dd6 Mon Sep 17 00:00:00 2001 From: Gert Robyns Date: Thu, 19 Sep 2024 14:44:24 +0200 Subject: [PATCH 3/5] remove CLEAN23 (#1922) #### Summary clean up CLEAN23 tags #### Work Item(s) Fixes [AB#546981](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/546981) --- .../App/Azure AD Plan/src/PlanIds.Codeunit.al | 11 --- .../src/DataCompression.Codeunit.al | 15 ---- .../DateTimeDialogObjects.PermissionSet.al | 17 ---- .../App/DotNet Aliases/src/dotnet.al | 38 --------- .../FeatureKeyObjects.PermissionSet.al | 7 +- .../Feature Key/src/FeatureManagement.Page.al | 15 +--- .../src/UpcomingChangesFactbox.Page.al | 80 ------------------- .../permissions/LanguageRead.PermissionSet.al | 17 ---- .../src/RecordLinkImpl.Codeunit.al | 9 --- .../src/RecordLinkManagement.Codeunit.al | 14 ---- .../SharePointAuthObjects.PermissionSet.al | 17 ---- .../TelemetryExec.PermissionSet.al | 17 ---- .../TimeZoneSelectionRead.PermissionSet.al | 16 ---- .../UpgradeTagsRead.PermissionSet.al | 17 ---- .../UpgradeTagsView.PermissionSet.al | 17 ---- .../Permissions/VideoRead.PermissionSet.al | 16 ---- 16 files changed, 2 insertions(+), 321 deletions(-) delete mode 100644 src/System Application/App/Date-Time Dialog/permissions/DateTimeDialogObjects.PermissionSet.al delete mode 100644 src/System Application/App/Feature Key/src/UpcomingChangesFactbox.Page.al delete mode 100644 src/System Application/App/Language/permissions/LanguageRead.PermissionSet.al delete mode 100644 src/System Application/App/SharePoint Authorization/permissions/SharePointAuthObjects.PermissionSet.al delete mode 100644 src/System Application/App/Telemetry/permissions/TelemetryExec.PermissionSet.al delete mode 100644 src/System Application/App/Time Zone Selection/Permissions/TimeZoneSelectionRead.PermissionSet.al delete mode 100644 src/System Application/App/Upgrade Tags/permissions/UpgradeTagsRead.PermissionSet.al delete mode 100644 src/System Application/App/Upgrade Tags/permissions/UpgradeTagsView.PermissionSet.al delete mode 100644 src/System Application/App/Video/Permissions/VideoRead.PermissionSet.al diff --git a/src/System Application/App/Azure AD Plan/src/PlanIds.Codeunit.al b/src/System Application/App/Azure AD Plan/src/PlanIds.Codeunit.al index a70efe5c4f..8691f58b97 100644 --- a/src/System Application/App/Azure AD Plan/src/PlanIds.Codeunit.al +++ b/src/System Application/App/Azure AD Plan/src/PlanIds.Codeunit.al @@ -150,17 +150,6 @@ codeunit 9027 "Plan Ids" exit(D365AdminGUIDTxt); end; -#if not CLEAN23 - /// - /// Returns the ID for the Internal Administrator plan. - /// - /// The ID for the Internal Administrator plan. - [Obsolete('Replaced by GetGlobalAdminPlanId()', '23.0')] - procedure GetInternalAdminPlanId(): Guid - begin - exit(GlobalAdminGUIDTxt); - end; -#endif /// /// Returns the ID for the Global Administrator plan. diff --git a/src/System Application/App/Data Compression/src/DataCompression.Codeunit.al b/src/System Application/App/Data Compression/src/DataCompression.Codeunit.al index 97bcd3c7fe..c2cf90c9ec 100644 --- a/src/System Application/App/Data Compression/src/DataCompression.Codeunit.al +++ b/src/System Application/App/Data Compression/src/DataCompression.Codeunit.al @@ -94,20 +94,6 @@ codeunit 425 "Data Compression" DataCompressionImpl.GetEntryList(EntryList); end; -#if not CLEAN23 - /// - /// Extracts an entry from the ZipArchive. - /// - /// The name of the ZipArchive entry to be extracted. - /// The OutStream to which binary content of the extracted entry is saved. - /// The length of the extracted entry. - [Obsolete('This function has been replaced by the function ExtractEntry(EntryName: Text; OutputOutStream: OutStream) which instead returns the entry length.', '23.0')] - procedure ExtractEntry(EntryName: Text; OutputOutStream: OutStream; var EntryLength: Integer) - begin - DataCompressionImpl.ExtractEntry(EntryName, OutputOutStream, EntryLength); - end; - -#endif /// /// Extracts an entry from the ZipArchive. /// @@ -189,4 +175,3 @@ codeunit 425 "Data Compression" DataCompressionImpl.GZipDecompress(InputInStream, DecompressedOutStream); end; } - diff --git a/src/System Application/App/Date-Time Dialog/permissions/DateTimeDialogObjects.PermissionSet.al b/src/System Application/App/Date-Time Dialog/permissions/DateTimeDialogObjects.PermissionSet.al deleted file mode 100644 index c72522c167..0000000000 --- a/src/System Application/App/Date-Time Dialog/permissions/DateTimeDialogObjects.PermissionSet.al +++ /dev/null @@ -1,17 +0,0 @@ -#if not CLEAN23 -// ------------------------------------------------------------------------------------------------ -// Copyright (c) Microsoft Corporation. All rights reserved. -// Licensed under the MIT License. See License.txt in the project root for license information. -// ------------------------------------------------------------------------------------------------ - -namespace System.DateTime; - -permissionset 684 "Date-Time Dialog - Objects" -{ - Access = Public; - Assignable = false; - ObsoleteState = Pending; - ObsoleteReason = 'This permission set is replaced with inherent permissions and is no longer needed.'; - ObsoleteTag = '23.0'; -} -#endif \ No newline at end of file diff --git a/src/System Application/App/DotNet Aliases/src/dotnet.al b/src/System Application/App/DotNet Aliases/src/dotnet.al index 3d6c90fe62..a0c3eb9119 100644 --- a/src/System Application/App/DotNet Aliases/src/dotnet.al +++ b/src/System Application/App/DotNet Aliases/src/dotnet.al @@ -800,43 +800,6 @@ dotnet Culture = 'neutral'; PublicKeyToken = '31bf3856ad364e35'; -#if not CLEAN23 - type("Microsoft.Dynamics.Nav.PowerBIEmbedded.Models.ImportedReport"; "ImportedReport") - { - } - - type("Microsoft.Dynamics.Nav.PowerBIEmbedded.Models.ImportedReportRequestList"; "ImportedReportRequestList") - { - } - - type("Microsoft.Dynamics.Nav.PowerBIEmbedded.Models.ImportedReportResponse"; "ImportedReportResponse") - { - } - - type("Microsoft.Dynamics.Nav.PowerBIEmbedded.Models.ImportedReportResponseList"; "ImportedReportResponseList") - { - } - - type("Microsoft.Dynamics.Nav.PowerBIEmbedded.Models.ImportReportRequest"; "ImportReportRequest") - { - } - - type("Microsoft.Dynamics.Nav.PowerBIEmbedded.Models.ImportReportRequestList"; "ImportReportRequestList") - { - } - - type("Microsoft.Dynamics.Nav.PowerBIEmbedded.Models.ImportReportResponse"; "ImportReportResponse") - { - } - - type("Microsoft.Dynamics.Nav.PowerBIEmbedded.Models.ImportReportResponseList"; "ImportReportResponseList") - { - } - - type("Microsoft.Dynamics.Nav.PowerBIEmbedded.ServiceWrapper"; "ServiceWrapper") - { - } -#endif type("Microsoft.Dynamics.Nav.PowerBIEmbedded.Models.ReturnedReport"; "ReturnedReport") { } @@ -2201,4 +2164,3 @@ dotnet } } } - diff --git a/src/System Application/App/Feature Key/permissions/FeatureKeyObjects.PermissionSet.al b/src/System Application/App/Feature Key/permissions/FeatureKeyObjects.PermissionSet.al index 5331d92326..28553f7e79 100644 --- a/src/System Application/App/Feature Key/permissions/FeatureKeyObjects.PermissionSet.al +++ b/src/System Application/App/Feature Key/permissions/FeatureKeyObjects.PermissionSet.al @@ -13,10 +13,5 @@ permissionset 2609 "Feature Key - Objects" Permissions = codeunit "Feature Management Facade" = X, page "Feature Management" = X, page "Schedule Feature Data Update" = X, -#if not CLEAN23 -#pragma warning disable AL0432 - page "Upcoming Changes Factbox" = X, -#pragma warning restore AL0432 -#endif table "Feature Data Update Status" = X; -} +} \ No newline at end of file diff --git a/src/System Application/App/Feature Key/src/FeatureManagement.Page.al b/src/System Application/App/Feature Key/src/FeatureManagement.Page.al index 836d19cefb..744edcdc28 100644 --- a/src/System Application/App/Feature Key/src/FeatureManagement.Page.al +++ b/src/System Application/App/Feature Key/src/FeatureManagement.Page.al @@ -160,19 +160,6 @@ page 2610 "Feature Management" } } } -#if not CLEAN23 - area(FactBoxes) - { - part("Upcoming Changes FactBox"; "Upcoming Changes Factbox") - { - ApplicationArea = All; - Visible = false; - ObsoleteReason = 'Replaced by teaching tips'; - ObsoleteState = Pending; - ObsoleteTag = '23.0'; - } - } -#endif } actions { @@ -378,4 +365,4 @@ page 2610 "Feature Management" local procedure OnOpenFeatureMgtPage(var FeatureIDFilter: Text; var IgnoreFilter: Boolean) begin end; -} +} \ No newline at end of file diff --git a/src/System Application/App/Feature Key/src/UpcomingChangesFactbox.Page.al b/src/System Application/App/Feature Key/src/UpcomingChangesFactbox.Page.al deleted file mode 100644 index ddeb26e624..0000000000 --- a/src/System Application/App/Feature Key/src/UpcomingChangesFactbox.Page.al +++ /dev/null @@ -1,80 +0,0 @@ -#if not CLEAN23 -// ------------------------------------------------------------------------------------------------ -// Copyright (c) Microsoft Corporation. All rights reserved. -// Licensed under the MIT License. See License.txt in the project root for license information. -// ------------------------------------------------------------------------------------------------ - -namespace System.Environment.Configuration; - -/// -/// Factbox part page that enables a user to learn more about upcoming changes -/// -page 2611 "Upcoming Changes Factbox" -{ - PageType = CardPart; - Caption = 'Managing change'; - Extensible = false; - ObsoleteReason = 'Replaced by teaching tips'; - ObsoleteState = Pending; - ObsoleteTag = '23.0'; - - layout - { - area(Content) - { - group(Header) - { - ShowCaption = false; - group(DescLine1) - { - ShowCaption = false; - InstructionalText = 'Some new features are turned off when Dynamics 365 Business Central is updated to a newer version. These features are optional for a period of time until they are automatically enabled for all users in a later software update.'; - } - group(DescLine2) - { - ShowCaption = false; - InstructionalText = 'You can prepare in advance by enabling these features for all users on the right environment at the right time that suits your schedule.'; - } - group(Links) - { - ShowCaption = false; - InstructionalText = ' '; - field(LearnMoreNewFeatures; LearnMoreNewFeaturesLbl) - { - ApplicationArea = All; - Editable = false; - Caption = 'Learn more about managing features.'; - ShowCaption = false; - ToolTip = 'Learn more about feature management.'; - - trigger OnDrillDown() - begin - Hyperlink(LearnMoreAboutPreviewProcessUrlTxt); - end; - } - - field(ReleasePlan; ReleasePlanLbl) - { - ApplicationArea = All; - Editable = false; - ShowCaption = false; - Caption = 'See the Release Plan'; - ToolTip = 'See the Release Plan.'; - - trigger OnDrillDown() - begin - Hyperlink(ReleasePlanUrlTxt); - end; - } - } - } - } - } - - var - LearnMoreNewFeaturesLbl: Label 'Learn more about feature management.'; - ReleasePlanLbl: Label 'See the Release Plan'; - LearnMoreAboutPreviewProcessUrlTxt: Label 'https://go.microsoft.com/fwlink/?linkid=2112707', Locked = true; - ReleasePlanUrlTxt: Label 'https://go.microsoft.com/fwlink/?linkid=2047422', Locked = true; -} -#endif \ No newline at end of file diff --git a/src/System Application/App/Language/permissions/LanguageRead.PermissionSet.al b/src/System Application/App/Language/permissions/LanguageRead.PermissionSet.al deleted file mode 100644 index 0f79abcf1b..0000000000 --- a/src/System Application/App/Language/permissions/LanguageRead.PermissionSet.al +++ /dev/null @@ -1,17 +0,0 @@ -#if not CLEAN23 -// ------------------------------------------------------------------------------------------------ -// Copyright (c) Microsoft Corporation. All rights reserved. -// Licensed under the MIT License. See License.txt in the project root for license information. -// ------------------------------------------------------------------------------------------------ - -namespace System.Globalization; - -permissionset 54 "Language - Read" -{ - Access = Public; - Assignable = false; - ObsoleteState = Pending; - ObsoleteReason = 'This permission set is replaced with inherent permissions and is no longer needed.'; - ObsoleteTag = '23.0'; -} -#endif \ No newline at end of file diff --git a/src/System Application/App/Record Link Management/src/RecordLinkImpl.Codeunit.al b/src/System Application/App/Record Link Management/src/RecordLinkImpl.Codeunit.al index fff48f700d..68fdb328d5 100644 --- a/src/System Application/App/Record Link Management/src/RecordLinkImpl.Codeunit.al +++ b/src/System Application/App/Record Link Management/src/RecordLinkImpl.Codeunit.al @@ -26,15 +26,7 @@ codeunit 4470 "Record Link Impl." procedure CopyLinks(FromRecordVariant: Variant; ToRecordVariant: Variant) var RecordRefTo: RecordRef; -#if not CLEAN23 - SkipReset: Boolean; -#endif begin -#if not CLEAN23 -#pragma warning disable AL0432 - RecordLinkManagement.OnBeforeCopyLinks(FromRecordVariant, ToRecordVariant, SkipReset); -#pragma warning restore AL0432 -#endif RecordRefTo.GetTable(ToRecordVariant); RecordRefTo.CopyLinks(FromRecordVariant); RecordLinkManagement.OnAfterCopyLinks(FromRecordVariant, ToRecordVariant); @@ -138,4 +130,3 @@ codeunit 4470 "Record Link Impl." WindowDialog.Close(); end; } - diff --git a/src/System Application/App/Record Link Management/src/RecordLinkManagement.Codeunit.al b/src/System Application/App/Record Link Management/src/RecordLinkManagement.Codeunit.al index f376fae902..5259811639 100644 --- a/src/System Application/App/Record Link Management/src/RecordLinkManagement.Codeunit.al +++ b/src/System Application/App/Record Link Management/src/RecordLinkManagement.Codeunit.al @@ -66,19 +66,6 @@ codeunit 447 "Record Link Management" RecordLinkImpl.RemoveOrphanedLinks(); end; -#if not CLEAN23 - /// - /// Integration event for before copying links. - /// - /// The source record from which links are copied. - /// The destination record to which links are copied. - /// Out parameter not used anymore. Obsolete. - [Obsolete('Not used anymore.', '23.0')] - [IntegrationEvent(false, false)] - internal procedure OnBeforeCopyLinks(FromRecord: Variant; ToRecord: Variant; var SkipReset: Boolean) - begin - end; -#endif /// /// Integration event for after copying links from one record to the other. @@ -90,4 +77,3 @@ codeunit 447 "Record Link Management" begin end; } - diff --git a/src/System Application/App/SharePoint Authorization/permissions/SharePointAuthObjects.PermissionSet.al b/src/System Application/App/SharePoint Authorization/permissions/SharePointAuthObjects.PermissionSet.al deleted file mode 100644 index aba618b7aa..0000000000 --- a/src/System Application/App/SharePoint Authorization/permissions/SharePointAuthObjects.PermissionSet.al +++ /dev/null @@ -1,17 +0,0 @@ -#if not CLEAN23 -// ------------------------------------------------------------------------------------------------ -// Copyright (c) Microsoft Corporation. All rights reserved. -// Licensed under the MIT License. See License.txt in the project root for license information. -// ------------------------------------------------------------------------------------------------ - -namespace System.Integration.Sharepoint; - -permissionset 9150 "SharePoint Auth. - Objects" -{ - Access = Public; - Assignable = false; - ObsoleteState = Pending; - ObsoleteReason = 'This permission set is replaced with inherent permissions and is no longer needed.'; - ObsoleteTag = '23.0'; -} -#endif \ No newline at end of file diff --git a/src/System Application/App/Telemetry/permissions/TelemetryExec.PermissionSet.al b/src/System Application/App/Telemetry/permissions/TelemetryExec.PermissionSet.al deleted file mode 100644 index f04274051f..0000000000 --- a/src/System Application/App/Telemetry/permissions/TelemetryExec.PermissionSet.al +++ /dev/null @@ -1,17 +0,0 @@ -#if not CLEAN23 -// ------------------------------------------------------------------------------------------------ -// Copyright (c) Microsoft Corporation. All rights reserved. -// Licensed under the MIT License. See License.txt in the project root for license information. -// ------------------------------------------------------------------------------------------------ - -namespace System.Telemetry; - -permissionset 8703 "Telemetry - Exec" -{ - Access = Public; - Assignable = false; - ObsoleteState = Pending; - ObsoleteReason = 'This permission set is replaced with inherent permissions and is no longer needed.'; - ObsoleteTag = '23.0'; -} -#endif \ No newline at end of file diff --git a/src/System Application/App/Time Zone Selection/Permissions/TimeZoneSelectionRead.PermissionSet.al b/src/System Application/App/Time Zone Selection/Permissions/TimeZoneSelectionRead.PermissionSet.al deleted file mode 100644 index 1a77215d42..0000000000 --- a/src/System Application/App/Time Zone Selection/Permissions/TimeZoneSelectionRead.PermissionSet.al +++ /dev/null @@ -1,16 +0,0 @@ -#if not CLEAN23 -// ------------------------------------------------------------------------------------------------ -// Copyright (c) Microsoft Corporation. All rights reserved. -// Licensed under the MIT License. See License.txt in the project root for license information. -// ------------------------------------------------------------------------------------------------ - -namespace System.DateTime; - -permissionset 9216 "Time Zone Selection - Read" -{ - Assignable = false; - ObsoleteState = Pending; - ObsoleteReason = 'This permission set is replaced with inherent permissions and is no longer needed.'; - ObsoleteTag = '23.0'; -} -#endif \ No newline at end of file diff --git a/src/System Application/App/Upgrade Tags/permissions/UpgradeTagsRead.PermissionSet.al b/src/System Application/App/Upgrade Tags/permissions/UpgradeTagsRead.PermissionSet.al deleted file mode 100644 index 08d5818f1f..0000000000 --- a/src/System Application/App/Upgrade Tags/permissions/UpgradeTagsRead.PermissionSet.al +++ /dev/null @@ -1,17 +0,0 @@ -#if not CLEAN23 -// ------------------------------------------------------------------------------------------------ -// Copyright (c) Microsoft Corporation. All rights reserved. -// Licensed under the MIT License. See License.txt in the project root for license information. -// ------------------------------------------------------------------------------------------------ - -namespace System.Upgrade; - -permissionset 9992 "Upgrade Tags - Read" -{ - Access = Public; - Assignable = false; - ObsoleteState = Pending; - ObsoleteReason = 'This permission set is replaced with inherent permissions and is no longer needed'; - ObsoleteTag = '23.0'; -} -#endif \ No newline at end of file diff --git a/src/System Application/App/Upgrade Tags/permissions/UpgradeTagsView.PermissionSet.al b/src/System Application/App/Upgrade Tags/permissions/UpgradeTagsView.PermissionSet.al deleted file mode 100644 index 9dab413a15..0000000000 --- a/src/System Application/App/Upgrade Tags/permissions/UpgradeTagsView.PermissionSet.al +++ /dev/null @@ -1,17 +0,0 @@ -#if not CLEAN23 -// ------------------------------------------------------------------------------------------------ -// Copyright (c) Microsoft Corporation. All rights reserved. -// Licensed under the MIT License. See License.txt in the project root for license information. -// ------------------------------------------------------------------------------------------------ - -namespace System.Upgrade; - -permissionset 9993 "Upgrade Tags - View" -{ - Access = Public; - Assignable = false; - ObsoleteState = Pending; - ObsoleteReason = 'This permission set is replaced with inherent permissions and is no longer needed.'; - ObsoleteTag = '23.0'; -} -#endif \ No newline at end of file diff --git a/src/System Application/App/Video/Permissions/VideoRead.PermissionSet.al b/src/System Application/App/Video/Permissions/VideoRead.PermissionSet.al deleted file mode 100644 index 9600010b57..0000000000 --- a/src/System Application/App/Video/Permissions/VideoRead.PermissionSet.al +++ /dev/null @@ -1,16 +0,0 @@ -#if not CLEAN23 -// ------------------------------------------------------------------------------------------------ -// Copyright (c) Microsoft Corporation. All rights reserved. -// Licensed under the MIT License. See License.txt in the project root for license information. -// ------------------------------------------------------------------------------------------------ - -namespace System.Media; - -permissionset 1470 "Video - Read" -{ - Assignable = false; - ObsoleteState = Pending; - ObsoleteReason = 'This permission set is replaced with inherent permissions and is no longer needed.'; - ObsoleteTag = '23.0'; -} -#endif \ No newline at end of file From 367502d43b4dc2f878653e0feaa4565e853b851f Mon Sep 17 00:00:00 2001 From: bcbuild-github-agent <137281497+bcbuild-github-agent@users.noreply.github.com> Date: Fri, 20 Sep 2024 01:56:12 -0700 Subject: [PATCH 4/5] [main] Update BCArtifact version. New value: 26.0.24443.0 (#2071) This PR contains the following changes: - Update BCArtifact version. New value: 26.0.24443.0 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: mazhelez --- .github/AL-Go-Settings.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/AL-Go-Settings.json b/.github/AL-Go-Settings.json index 7dddb24273..7dd4da19d0 100644 --- a/.github/AL-Go-Settings.json +++ b/.github/AL-Go-Settings.json @@ -5,7 +5,7 @@ "runs-on": "windows-latest", "cacheImageName": "", "UsePsSession": false, - "artifact": "https://bcinsider-fvh2ekdjecfjd6gk.b02.azurefd.net/sandbox/26.0.24375.0/base", + "artifact": "https://bcinsider-fvh2ekdjecfjd6gk.b02.azurefd.net/sandbox/26.0.24443.0/base", "country": "base", "useProjectDependencies": true, "repoVersion": "26.0", From 4441181a96f88d80d9de064f1d3ce180f8220bef Mon Sep 17 00:00:00 2001 From: Prangshuman Das <81367237+t-prda@users.noreply.github.com> Date: Fri, 20 Sep 2024 11:37:32 +0200 Subject: [PATCH 5/5] Bug: AI Test Capability Registration from Test Library does not work (#2066) #### Summary Use rename to change the primary key #### Work Item(s) Fixes [AB#549398](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/549398) --- .../Test Library/AI/src/CopilotTestLibrary.Codeunit.al | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/System Application/Test Library/AI/src/CopilotTestLibrary.Codeunit.al b/src/System Application/Test Library/AI/src/CopilotTestLibrary.Codeunit.al index ea34dedbe8..dd20227906 100644 --- a/src/System Application/Test Library/AI/src/CopilotTestLibrary.Codeunit.al +++ b/src/System Application/Test Library/AI/src/CopilotTestLibrary.Codeunit.al @@ -47,8 +47,8 @@ codeunit 132932 "Copilot Test Library" NavApp.GetCurrentModuleInfo(ModuleInfo); if CopilotSettings.Get(Capability, ModuleInfo.Id) then begin - CopilotSettings."App Id" := AppId; - CopilotSettings.Modify(); + CopilotSettings.Rename(Capability, AppId); + Commit(); end; end;