Drop support for sqlplus, sqlcl Liquibase ci/cd

[yevon]

What do you think about dropping support for sqlplus? I say it because I plan to add sqlcl liquibase ci/cd compatibility in liquibase, and for me I don't see any advantages of mantaining two different implementations as sqlcl can do everything and more than sqlplus can do.

[true-hb]

sorry, I need sqlplus, because we are still working with Oracle 11 in our company. I guess, I'm not the only one.

[yevon]

mmm ok, we will have to limit some features only if you have installed sqlcl.

[mickeypearce]

Yes, no problem, I think that SqlCl is set to execute by default, so no problem if some features don't work if you switch to sqlplus.

[mickeypearce]

hej! Latest version of sqlcl has some additional liquibase fatures... https://www.thatjeffsmith.com/archive/2021/10/versions-21-3-of-sqlcl-ords-sqldev-web-now-available/

[yevon]

Wow very interesting, I was waiting for this as standard Liquibase has support for this. I will try to have a look at it. We might even replace curent schema sql generator with sqlcl generator. I found it quite slow generating changelogs, it might have improved. I will have a look at this.

[yevon]

SQLcl Liquibase file structure is a bit different than oradew project structure, what do you thing about renaming some of the object type's to liquibase ones?

(Liquibase -> Current in oradew)

apex -> APEX
db_link -> New object type
function -> FUNCTIONS
index -> New object type
job -> New object type
object_grant -> New object type
package_body -> PACKAGE_BODIES
package_spec -> PACKAGES
procedure -> PROCEDURES
ref_constraint -> New object type
sequence -> New object type
synonym -> SYNONYMS
table -> TABLES
trigger -> TRIGGERS
type_body -> TYPE_BODIES
type_spec -> TYPES
view -> VIEWS

[yevon]

I will just create two new command, like import liquibase and deploy liquibase for keeping current compatibility.

[mickeypearce]

We already use a mapping for object types, I think we can extend it or create sth similar for luqibase:

oradew-vscode/src/cli/common/dbobject.ts

Lines 57 to 78 in 6372784

	const mapToOraObjectType = {
	packageSpec: "PACKAGE",
	procedure: "PROCEDURE",
	function: "FUNCTION",
	packageBody: "PACKAGE BODY",
	view: "VIEW",
	trigger: "TRIGGER",
	typeSpec: "TYPE",
	typeBody: "TYPE BODY",
	table: "TABLE",
	synonym: "SYNONYM",
	apex: "APEX",
	};
	const mapToOraObjectTypeAlt = {
	packageSpec: "PACKAGE_SPEC",
	packageBody: "PACKAGE_BODY",
	typeSpec: "TYPE_SPEC",
	typeBody: "TYPE_BODY",
	};
	const mapfromOraObjectType = invert(mapToOraObjectType);

oradew-vscode/src/cli/common/dbobject.ts

Lines 140 to 141 in 6372784

	const objectTypeOra = mapToOraObjectType[objectType] || objectType;
	const objectTypeOraAlt = mapToOraObjectTypeAlt[objectType] || objectTypeOra;

...

oradew-vscode/src/cli/common/dbobject.ts

Line 211 in 6372784

const type = mapfromOraObjectType[oraType] || oraType;