Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream Espruino Meta Issue #29

Open
3 of 7 tasks
kiranshila opened this issue Aug 18, 2020 · 0 comments
Open
3 of 7 tasks

Upstream Espruino Meta Issue #29

kiranshila opened this issue Aug 18, 2020 · 0 comments

Comments

@kiranshila
Copy link
Contributor

kiranshila commented Aug 18, 2020

I'd like to keep an issue open for the things we do that "patch" inconsistencies in the Espruino interpreter. The less we have to do to the compiled CLJS, the better I think. So if we close issues that "fix" bugs but don't really fix the interpreter, we should note that those bugs really still do exists and once they get fixed upstream, revert our change and really close the issue.

Issues we've patched that are also patched in upstream, waiting for binary release to revert our fix

Issues we've patched, but still exist upstream

  • All of the regex edge cases, like Problem parsing a regex #2 but there are a lot of them. See
    (let [main-js (-> (slurp "out/main.js")
    (string/replace "arguments" (str "[" argument-global "=arguments," argument-global "][1]"))
    (string/replace "/[\\\\\"\\b\\f\\n\\r\\t]/g" "/[\\\\\"\\f\\n\\r\\t]/g")
    (string/replace "goog.NONCE_PATTERN_=/^[\\w+/_-]+[=]{0,2}$/" "goog.NONCE_PATTERN_=null")
    (string/replace "/^((https:)?\\/\\/[0-9a-z.:[\\]-]+\\/|\\/[^/\\\\]|[^:/\\\\%]+\\/|[^:/\\\\%]*[?#]|about:blank#)/i" "null")
    (string/replace "/^(?:(?:https?|mailto|ftp):|[^:/?#]*(?:[/?#]|$))/i" "null")
    (string/replace "a: {" "{")
    (string/replace "a:for" "for")
    (string/replace "goog.uri.utils.splitRe_=/^(?:([^:/?#.]+):)?(?:\\/\\/(?:([^/?#]*)@)?([^/#?]*?)(?::([0-9]+))?(?=[/#?]|$))?([^?#]+)?(?:\\?([^#]*))?(?:#([\\s\\S]*))?$/" "goog.uri.utils.splitRe_=null")
    (string/replace "= /^(?:([^:/?#.]+):)?(?:\\/\\/(?:([^/?#]*)@)?([^/#?]*?)(?::([0-9]+))?(?=[/#?]|$))?([^?#]+)?(?:\\?([^#]*))?(?:#([\\s\\S]*))?$/" "= null"))
  • try/catch doesn't return the value of try on success - it must be wrapped in a fn and called with return

Issues that we've not patched, but are patched upstream, waiting for binary release to close

Issues that we've not patched and still exist upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant