Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No CSS with Meteor 1.3 (beta 8) #58

Open
nicooprat opened this issue Feb 16, 2016 · 5 comments
Open

No CSS with Meteor 1.3 (beta 8) #58

nicooprat opened this issue Feb 16, 2016 · 5 comments

Comments

@nicooprat
Copy link

Tried this package with the latest beta of Meteor 1.3, everything is working but it looks like the CSS is not loaded. Downgrading to Meteor 1.2.1 resolved the issue.

Any plans to support the next version of Meteor ?

@quape
Copy link

quape commented Mar 4, 2016

Same here. CSS is not pushed into the HTML header anymore.

@silkroadnomad
Copy link
Contributor

Hey I found
Inject.rawHead('avatar-styles', '<style>' + css + '</style>');in helpers.js

imho it seems to interfere with a bug in meteor 1.3rc2 too meteor/meteor#6515
I hope that crossposting that thing is the right thing todo and does not create more confusion.

@timothyarmes
Copy link
Contributor

I think we just need to use the latest version of meteor-inject-initial which is now compatible with 1.3. Anyone available to test and provide a PR?

@silkroadnomad
Copy link
Contributor

Thanks @timothyarmes I was trying to test this first time in my life for me here and it seems to work for me locally now but: I am still confused. :/ Maybe you can double check help me out?

Here is what I did:

  1. I forked and cloned this repo into my $PACKAGE_DIRS directory (did not change anything!)
  2. I forked and clone 'meteor-inject-initial' repo into my $PACKAGE_DIRS directory (did not change anything)
  3. I re-added this module with meteor add utilities:avatar and it loaded following
    jparker:crypto-core added, version 0.1.0 jparker:crypto-md5 added, version 0.1.1 jparker:gravatar added, version 0.3.1 meteorhacks:inject-initial added, version 1.0.4-rc.0 utilities:avatar added, version 0.9.2

So there should be a meteorhacks:inject-initial 1.0.4-rc.0 version somewhere (this is what @gadicc posted here meteorhacks/meteor-inject-initial#17 and here meteorhacks/meteor-inject-initial#18) but I cannot find this version weather in github nor in athmosphere is is published somewhere else?

So somebody (maybe its me) should point to 1.0.4-rc.0)
Please don't kill me if thats not 100% correct yet. ;)

@gadicc
Copy link

gadicc commented Mar 24, 2016

@inspiraluna, "preview" releases don't show up on the Atmosphere webpage (you can see them in Meteor with meteor show --show-all package though). And I admit, I've been pretty useless at tagging releases on GitHub since mrt did went away :>

Anyway, just released v1.0.4 official now, will hopefully make things easier :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants