Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with membrane rtsp after v0.7.2 #863

Open
gBillal opened this issue Sep 11, 2024 · 3 comments
Open

Issue with membrane rtsp after v0.7.2 #863

gBillal opened this issue Sep 11, 2024 · 3 comments

Comments

@gBillal
Copy link

gBillal commented Sep 11, 2024

Since v0.7.2 where the tcp socket is set to active mode. This causes issues when someone want full control of the underlying tcp socket.

In my case I get the socket and set active to false, so once I try to :gen_tcp.recv and the socket try to send a message in another process, I get the error {:error, :einval} (because the socket is set to active mode)

@Noarkhh
Copy link
Contributor

Noarkhh commented Sep 11, 2024

Hi, I see the issue. In membraneframework/membrane_rtsp#44 the behavior changes (after transferring control the session no longer tries to receive from that socket). Would it be okay if it's fixed there?

@gBillal
Copy link
Author

gBillal commented Sep 11, 2024

That's great, I'll wait for 0.10.0 release

@Noarkhh
Copy link
Contributor

Noarkhh commented Sep 18, 2024

I just released v0.10.0, give it a try :) Also gBillal/membrane_rtsp_plugin#12 is now ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants