{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":92553343,"defaultBranch":"master","name":"fmt","ownerLogin":"melton1968","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2017-05-26T22:36:25.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/976548?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1663247697.367388","currentOid":""},"activityList":{"items":[{"before":"365c3fbd258fb3df69007fc7a22c0472dd31dcbb","after":"4e8640ed90ac8751d4a8ca500b893cc8c4bb9668","ref":"refs/heads/master","pushedAt":"2024-04-05T12:37:30.000Z","pushType":"push","commitsCount":16,"pusher":{"login":"melton1968","name":"Mark Melton","path":"/melton1968","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/976548?s=80&v=4"},"commit":{"message":"Fix: enable `FMT_NORETURN` without exception support too (#3917)\n\nWhen building `format.cc` as such with GCC 13.2.1:\r\n\r\n    $ g++ -c format.cc -DFMT_EXCEPTIONS=0 -Wmissing-noreturn -Werror\r\n\r\nI get:\r\n\r\n    In file included from format.cc:8:\r\n    fmt/format-inl.h: In function ‘void fmt::v10::detail::assert_fail(const char*, int, const char*)’:\r\n    fmt/format-inl.h:30:15: error: function might be candidate for attribute ‘noreturn’ [-Werror=suggest-attribute=noreturn]\r\n       30 | FMT_FUNC void assert_fail(const char* file, int line, const char* message) {\r\n          |               ^~~~~~~~~~~\r\n    fmt/format-inl.h: In function ‘void fmt::v10::report_error(const char*)’:\r\n    fmt/format-inl.h:129:15: error: function might be candidate for attribute ‘noreturn’ [-Werror=suggest-attribute=noreturn]\r\n      129 | FMT_FUNC void report_error(const char* message) {\r\n          |               ^~~~~~~~~~~~\r\n    cc1plus: all warnings being treated as errors\r\n\r\nNote that, with `FMT_EXCEPTIONS` defined to 0:\r\n\r\n‣ report_error(const char *) uses FMT_THROW() which expands to calling\r\n  assert_fail().\r\n\r\n‣ assert_fail() calls std::terminate() which has the `[[noreturn]]`\r\n  attribute since C++11 [1].\r\n\r\nTherefore, with `FMT_EXCEPTIONS` defined to 0, both assert_fail() and\r\nreport_error() need to have the `[[noreturn]]` attribute too (if\r\navailable). In other words, `FMT_NORETURN` doesn't depend on\r\n`FMT_EXCEPTIONS`.\r\n\r\nAlso adding `FMT_NORETURN` to two on_error() functions which call\r\nreport_error(const char *).\r\n\r\nOther report_error() overloads eventually return, therefore they don't\r\nneed `FMT_NORETURN`.\r\n\r\n[1]: https://en.cppreference.com/w/cpp/error/terminate\r\n\r\nSigned-off-by: Philippe Proulx <eeppeliteloop@gmail.com>","shortMessageHtmlLink":"Fix: enable <code>FMT_NORETURN</code> without exception support too (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2221904571\" data-permission-text=\"Title is private\" data-url=\"https://github.com/fmtlib/fmt/issues/3917\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/fmtlib/fmt/pull/3917/hovercard\" href=\"https://github.com/fmtlib/fmt/pull/3917\">fmtlib#3917</a>)"}},{"before":"d65acc4e6cf111945d2df0ef524ed6c2f4a13427","after":"365c3fbd258fb3df69007fc7a22c0472dd31dcbb","ref":"refs/heads/master","pushedAt":"2024-03-19T13:14:54.000Z","pushType":"push","commitsCount":784,"pusher":{"login":"melton1968","name":"Mark Melton","path":"/melton1968","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/976548?s=80&v=4"},"commit":{"message":"Bump timeout","shortMessageHtmlLink":"Bump timeout"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNC0wNVQxMjozNzozMC4wMDAwMDBazwAAAAQo2PQn","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNC0wNVQxMjozNzozMC4wMDAwMDBazwAAAAQo2PQn","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wMy0xOVQxMzoxNDo1NC4wMDAwMDBazwAAAAQZoGLo"}},"title":"Activity · melton1968/fmt"}