Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: configurable target schema change settings by default #1781

Open
pnadolny13 opened this issue Jun 21, 2023 · 3 comments · May be fixed by #2504
Open

feat: configurable target schema change settings by default #1781

pnadolny13 opened this issue Jun 21, 2023 · 3 comments · May be fixed by #2504
Milestone
v0.42.0

Comments

@pnadolny13
Copy link
Contributor

The target sdk sql connector class has allow_column_alter which is set by the target developer in the connector implementation. We should make this a configuration option thats available to the user by default. It will let us have a consistent enum of options available to the user with a consistent config name instead of letting each developer implement it themselves in slightly different ways.
@pnadolny13 pnadolny13 mentioned this issue Jun 21, 2023
Closed
@stale Stale
Copy link

stale bot commented Jun 20, 2024

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label Jun 20, 2024
@pnadolny13
Copy link
Contributor Author

Still relevant. @edgarrmondragon this might be something we want to have available as an option in Arch so having a way to control it externally would be nice eventually.

@stale stale bot removed the stale label Jun 21, 2024
@edgarrmondragon
Copy link
Collaborator

Still relevant. @edgarrmondragon this might be something we want to have available as an option in Arch so having a way to control it externally would be nice eventually.

Makes sense. Should be pretty quick to implement too fwiw.

@edgarrmondragon edgarrmondragon linked a pull request Jun 25, 2024 that will close this issue
feat: In SQL targets, users can now disable column type alterations with the allow_column_alter built-in setting #2504
Draft
@edgarrmondragon edgarrmondragon added this to the 0.41.0 milestone Aug 14, 2024
@edgarrmondragon edgarrmondragon modified the milestones: v0.41.0, v0.42.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.42.0
2 participants
@edgarrmondragon @pnadolny13