Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.10.0] AI-powered search changes #612

Open
6 tasks
brunoocasali opened this issue Aug 27, 2024 · 1 comment · May be fixed by #554
Open
6 tasks

[v1.10.0] AI-powered search changes #612

brunoocasali opened this issue Aug 27, 2024 · 1 comment · May be fixed by #554
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@brunoocasali
Copy link
Member

Following this central issue

Explanation of the feature

  • Rest embedder
    • Removed parameters: query, inputField, inputType, pathToEmbeddings and embeddingObject.
    • Replaced by request and response
    • New parameter: headers
  • Add url parameter to the OpenAI embedder
  • dimensions is now available as an optional parameter for ollama embedders.

Usage: https://meilisearch.notion.site/v1-10-AI-search-changes-737c9d7d010d4dd685582bf5dab579e2?pvs=74

TODO

  • Rest embedder
    • Remove the following parameters: query, inputField, inputType, pathToEmbeddings and embeddingObject.
    • Add the new parameters request, response and headers (cf usage for more information)
  • Add url parameter to the OpenAI embedder
  • Add dimensions for Ollama embedders.
  • Update the tests accordingly
@brunoocasali brunoocasali added enhancement New feature or request good first issue Good for newcomers labels Aug 27, 2024
@CommanderStorm
Copy link

CommanderStorm commented Aug 29, 2024 •
edited
Loading

Removals and request and response are done.
Totally overlooked the headers-additon.

Will add that now

@CommanderStorm CommanderStorm linked a pull request Aug 29, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support embedders setting CommanderStorm/meilisearch-rust
2 participants
@brunoocasali @CommanderStorm