By the way how we can unregister the serviceworker

[webdawe]

Hi,
for instance while we disable extension through the config settings there should be a way we can un register the service worker.
What I tried is amend register.phtml with the following

But it will register and then unregister. is this the correct way of un-register existing serviceworker?

[tgerulaitis]

I don't think that's correct. Like you mentioned, this will register the service worker and then unregister it, because you're calling the register() method to retrieve the registration.

I think a better solution would be to use the getRegistration() method to retrieve the registration, e.g.:

if ('serviceWorker' in navigator) {
    navigator.serviceWorker.getRegistration().then(function (registration) {
        registration.unregister();
    });
}

Two notes:

1. I've not tested this snippet of code, so it comes with no warranty.
2. This should return the service worker registration that's relevant for the current scope, but I'm not sure if it will return the most relevant one or if it's even possible to have multiple service workers apply to the same scope.

[webdawe]

Thank you so much @tgerulaitis
I have tested locally and it seems to be working and we have only one service worker running so no need to worry about it much at the moment.

Anil

[tgerulaitis]

Glad to have helped :)

I'll keep this issue open as I think this would be a good enhancement to build into the extension whenever there's time.

[webdawe]

thanks @tgerulaitis

I have added an if condition to avoid showing error registration undefined
(function () { if ('serviceWorker' in navigator) { navigator.serviceWorker.getRegistration().then(function (registration) { if (registration){ registration.unregister(); } }); } })();

Thanks
Anil