From 559ee88d7850f8dd1c063d6bdc2f59f07f0789b9 Mon Sep 17 00:00:00 2001 From: Piotr Date: Tue, 5 Aug 2014 19:31:12 +0200 Subject: [PATCH 1/3] simplified createDirectory method Additionally fixes problem with nested directories with mixed up slashes and backslashes, ie `code-browser\app/config/packages/jones/web-artisan/\` --- src/PHPCodeBrowser/Helper/IOHelper.php | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/PHPCodeBrowser/Helper/IOHelper.php b/src/PHPCodeBrowser/Helper/IOHelper.php index a454d8d..1076552 100644 --- a/src/PHPCodeBrowser/Helper/IOHelper.php +++ b/src/PHPCodeBrowser/Helper/IOHelper.php @@ -155,16 +155,12 @@ public function loadFile($fileName) */ public function createDirectory($target) { - if (DIRECTORY_SEPARATOR == substr($target, - 1, 1)) { - $target = substr($target, 0, -1); - } - $dirs = explode(DIRECTORY_SEPARATOR, $target); - $path = ''; - foreach ($dirs as $folder) { - if (!is_dir($path = $path . $folder . DIRECTORY_SEPARATOR)) { - mkdir($path); - } - } + $target = rtrim($target, DIRECTORY_SEPARATOR); + + if (!is_dir($target)) + { + mkdir($target, 0777, true); + } } /** From 5f946ab3888a1df26699cf826231b272c3984db7 Mon Sep 17 00:00:00 2001 From: Piotr Date: Tue, 5 Aug 2014 19:33:32 +0200 Subject: [PATCH 2/3] Fixed up indent --- src/PHPCodeBrowser/Helper/IOHelper.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PHPCodeBrowser/Helper/IOHelper.php b/src/PHPCodeBrowser/Helper/IOHelper.php index 1076552..1d7581a 100644 --- a/src/PHPCodeBrowser/Helper/IOHelper.php +++ b/src/PHPCodeBrowser/Helper/IOHelper.php @@ -158,9 +158,9 @@ public function createDirectory($target) $target = rtrim($target, DIRECTORY_SEPARATOR); if (!is_dir($target)) - { - mkdir($target, 0777, true); - } + { + mkdir($target, 0777, true); + } } /** From 8e3dc1699fcbaedcad8cb35c21e66857a8586d16 Mon Sep 17 00:00:00 2001 From: Piotr Date: Tue, 5 Aug 2014 19:35:35 +0200 Subject: [PATCH 3/3] Indent again --- src/PHPCodeBrowser/Helper/IOHelper.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PHPCodeBrowser/Helper/IOHelper.php b/src/PHPCodeBrowser/Helper/IOHelper.php index 1d7581a..4e669fa 100644 --- a/src/PHPCodeBrowser/Helper/IOHelper.php +++ b/src/PHPCodeBrowser/Helper/IOHelper.php @@ -158,9 +158,9 @@ public function createDirectory($target) $target = rtrim($target, DIRECTORY_SEPARATOR); if (!is_dir($target)) - { - mkdir($target, 0777, true); - } + { + mkdir($target, 0777, true); + } } /**