Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ditch the indentation? #44

Closed
matthewmueller opened this issue Sep 17, 2021 · 1 comment
Closed

Ditch the indentation? #44

matthewmueller opened this issue Sep 17, 2021 · 1 comment

Comments

@matthewmueller
Copy link

matthewmueller commented Sep 17, 2021

Hey there, thanks for creating this package. I use it in all my tests. Would you be open to removing the tab in front?

The misalignment with other printed logs bugs me a bit (very subjective of course):

CleanShot 2021-09-16 at 21 50 23@2x

And with the colors, I think there's enough visual separation:

image

If you're up for this change, I'd be happy to open a PR.

@flowchartsman
Copy link
Collaborator

Thanks for the issue!

Printing test messages with indentation is how testing.T.Log() does it, so it's probably best not to deviate from that, especially since a fix for #47 is likely going to involve invoking t.Log() directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants