Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solution #4863

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add solution #4863

wants to merge 1 commit into from

Conversation

clavigo
Copy link

@clavigo clavigo commented Sep 25, 2024

  • Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
  • Each BEM block has its own separate file
  • All Typical Mistakes from BEM lesson theory are checked.
  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this Pull Request! 👏 There are a few minor issues to keep in mind for next time, such as formatting long attribute values and maintaining consistent indentation. Also, remember to keep an eye out for typos, like the one in the .stars--5 selector. Nevertheless, these are small improvements and don't impact the overall functionality of your code. Keep up the good work! 💻🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines 15 to +62
<body>
<h1>Stars</h1>
<div class="stars stars--0">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<div class="stars stars--1">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<div class="stars stars--2">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<div class="stars stars--3">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<div class="stars stars--5">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add empty lines between multiline sibling blocks of HTML to add some 'air' and simplify reading. For example, add an empty line between the closing of one '.stars' block and the opening

of the next one.

<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep your attributes correctly formatted. If the HTML element has long attribute values or a number of attributes is more than 2, start each one on a new line with 2-space indentation relative to the tag. The tag content attribute value is too long and should be broken down into multiple lines.

Comment on lines +6 to +8
.stars {
display: flex;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of the * selector is discouraged due to performance reasons. In this case, it is not present, but keep this in mind for future reference.

Comment on lines +19 to +21
.stars--1 .stars__star:nth-child(-n + 1) {
background-image: url(/src/images/star-active.svg);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good practice to use classes for styling instead of tag names. However, in this code, you're properly using classes, which is great.

Comment on lines +35 to +37
.stars--5 .stars__star:nth-of-type(-n + 6) {
background-image: url(/src/images/star-active.svg);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a typo in the selector .stars--5 .stars__star:nth-of-type(-n + 6). It should be -n + 5 to match exactly five stars. Please correct it to .stars--5 .stars__star:nth-of-type(-n + 5).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants