Develop #4846
Open
Develop #4846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Great job on your stars__star.css file! It's well-structured and meets all our checklist requirements. Keep up the good work! Remember, even though we strive for perfection, it's okay to have minor issues. They offer learning opportunities and can be addressed in future updates. Keep coding and stay awesome! 🌟👍
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
src/index.html
Outdated
Comment on lines
19
to
62
| <body class="stars__body"> | ||
| <section class="stars__section"> | ||
| <article class="stars stars--0"> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| </article> | ||
| <article class="stars stars--1"> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| </article> | ||
| <article class="stars stars--2"> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| </article> | ||
| <article class="stars stars--3"> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| </article> | ||
| <article class="stars stars--4"> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| </article> | ||
| <article class="stars stars--5"> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| </article> |
There was a problem hiding this comment.
There should be empty lines between multiline sibling blocks of HTML. Please add empty lines between the <article> elements to improve readability.
volodymyr-soltys97
suggested changes
Sep 21, 2024
src/css/stars/stars.css
Outdated
Comment on lines
9
to
27
| .stars--1 .stars__star:nth-child(-n + 1) { | ||
| background-image: url(../../images/star-active.svg); | ||
| } | ||
|
|
||
| .stars--2 .stars__star:nth-child(-n + 2) { | ||
| background-image: url(../../images/star-active.svg); | ||
| } | ||
|
|
||
| .stars--3 .stars__star:nth-child(-n + 3) { | ||
| background-image: url(../../images/star-active.svg); | ||
| } | ||
|
|
||
| .stars--4 .stars__star:nth-child(-n + 4) { | ||
| background-image: url(../../images/star-active.svg); | ||
| } | ||
|
|
||
| .stars--5 .stars__star:nth-child(-n + 5) { | ||
| background-image: url(../../images/star-active.svg); | ||
| } |
There was a problem hiding this comment.
These selectors must be separated by commas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
TEST REPORT LINK
Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
Each BEM block has its own separate file
All
Typical MistakesfromBEMlesson theory are checked.Code follows all the Code Style Rules ❗️