Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #4845

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #4845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ca2ab9
add task solution
alena-bondar Sep 20, 2024
cf7e13d
fix some styles
alena-bondar Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ Follow

❗️ Replace `<your_account>` with your Github username and copy the links to `Pull Request` description:

- [DEMO LINK](https://<your_account>.github.io/layout_stars/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_stars/report/html_report/)
- [DEMO LINK](https://alena-bondar.github.io/layout_stars/)
- [TEST REPORT LINK](https://alena-bondar.github.io/layout_stars/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
48 changes: 47 additions & 1 deletion src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,52 @@
/>
</head>
<body>
<h1>Stars</h1>
<div class="stars stars--0">
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
</div>

<div class="stars stars--1">
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
</div>

<div class="stars stars--2">
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
</div>

<div class="stars stars--3">
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
</div>

<div class="stars stars--4">
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
</div>

<div class="stars stars--5">
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
</div>
Comment on lines 15 to +62
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add empty lines between multiline sibling blocks of HTML to simplify reading the code. However, make sure not to add them between parent and child elements. For example, there should be an empty line between the closing </div> tag of one block and the opening <div> tag of the next block.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already have an empty line between the closing tag of one block and the opening

tag of the next block.

Comment on lines 15 to +62
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tag and its children should have a 2-space indentation to reflect the nesting level properly.

</body>
</html>
49 changes: 48 additions & 1 deletion src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,48 @@
/* add styles here */
body {
margin: 0;
padding: 0;
box-sizing: border-box;
}

.stars {
display: flex;
justify-content: flex-start;
}

.stars__star {
font-family: Arial, sans-serif;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to use fallback fonts - alternative font-family in case the main one doesn't work. Here you could specify a fallback font-family for .stars__star if you have a custom font applied.

width: 16px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to use fallback fonts - alternative font-family in case the main one doesn't work. It's a good practice to specify a generic family as a fallback. For example, font-family: Arial, 'Helvetica Neue', Helvetica, sans-serif; ensures that if Arial is not available, the browser will try Helvetica Neue, then Helvetica, and finally any available sans-serif font.

height: 16px;
margin-right: 4px;
background-image: url(./images/star.svg);
background-repeat: no-repeat;
background-position: center;
}

.stars__star:last-child {
margin-right: 0;
}

.stars--0 .stars__star:nth-child(-n + 0) {
background-image: url('./images/star-active.svg');
}

.stars--1 .stars__star:nth-child(-n + 1) {
background-image: url('./images/star-active.svg');
}

.stars--2 .stars__star:nth-child(-n + 2) {
background-image: url('./images/star-active.svg');
}

.stars--3 .stars__star:nth-child(-n + 3) {
background-image: url('./images/star-active.svg');
}

.stars--4 .stars__star:nth-child(-n + 4) {
background-image: url('./images/star-active.svg');
}

.stars--5 .stars__star:nth-child(-n + 5) {
background-image: url('./images/star-active.svg');
}
Loading