Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solution #4830

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add solution #4830

wants to merge 4 commits into from

Conversation

Vl-Tsr
Copy link

@Vl-Tsr Vl-Tsr commented Sep 14, 2024

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! It looks like we need to make a few adjustments regarding the way we're styling elements. Specifically, we should avoid styling directly using tag names and instead use classes. This is a best practice that helps keep our CSS maintainable and our HTML semantic. Also, let's make sure that our margins are consistent to avoid any layout issues, and we should tidy up our HTML formatting for better readability. Keep up the great work, and with these changes, your code will be even more solid! 👍💻

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
src/style.css Outdated Show resolved Hide resolved
src/style.css Outdated Show resolved Hide resolved
src/style.css Outdated Show resolved Hide resolved
src/style.css Outdated Show resolved Hide resolved
src/style.css Outdated Show resolved Hide resolved
src/style.css Outdated Show resolved Hide resolved
src/style.css Outdated Show resolved Hide resolved
Copy link
Author

@Vl-Tsr Vl-Tsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add solution

@Vl-Tsr Vl-Tsr marked this pull request as draft September 14, 2024 15:30
Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done, just one suggestion.

src/style.css Outdated
Comment on lines 18 to 36
.stars--5 .stars__star {
background-image: url(./images/star-active.svg);
}

.stars--1 .stars__star:first-child {
background-image: url(./images/star-active.svg);
}

.stars--2 .stars__star:nth-child(-n + 2) {
background-image: url(./images/star-active.svg);
}

.stars--3 .stars__star:nth-child(-n + 3) {
background-image: url(./images/star-active.svg);
}

.stars--4 .stars__star:not(:last-child) {
background-image: url(./images/star-active.svg);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be simplified:

Suggested change
.stars--5 .stars__star {
background-image: url(./images/star-active.svg);
}
.stars--1 .stars__star:first-child {
background-image: url(./images/star-active.svg);
}
.stars--2 .stars__star:nth-child(-n + 2) {
background-image: url(./images/star-active.svg);
}
.stars--3 .stars__star:nth-child(-n + 3) {
background-image: url(./images/star-active.svg);
}
.stars--4 .stars__star:not(:last-child) {
background-image: url(./images/star-active.svg);
}
.stars--1 .stars__star:nth-child(-n + 1),
.stars--2 .stars__star:nth-child(-n + 2),
.stars--3 .stars__star:nth-child(-n + 3),
.stars--4 .stars__star:nth-child(-n + 4),
.stars--5 .stars__star:nth-child(-n + 5) {
background-image: url(./images/star-active.svg);
}

@Vl-Tsr Vl-Tsr marked this pull request as ready for review September 15, 2024 17:07
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants