From e3704a0b46995997bef71dd5edc8e4ae2180be1f Mon Sep 17 00:00:00 2001 From: Andrzej Przedecki <108667553+aprzedecki@users.noreply.github.com> Date: Fri, 21 Jun 2024 09:12:09 +0200 Subject: [PATCH 1/2] Added mustCallSuper requirement If an action has already before override, the mixin won't work --- lib/src/action_mixins.dart | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/src/action_mixins.dart b/lib/src/action_mixins.dart index cce2ab5..f37a650 100644 --- a/lib/src/action_mixins.dart +++ b/lib/src/action_mixins.dart @@ -1,4 +1,5 @@ import 'dart:async'; +import 'package:meta/meta.dart'; import 'package:async_redux/async_redux.dart'; import 'package:connectivity_plus/connectivity_plus.dart'; @@ -72,6 +73,7 @@ mixin CheckInternet on ReduxAction { return await (Connectivity().checkConnectivity()); } + @mustCallSuper @override Future before() async { var result = await checkConnectivity(); @@ -148,6 +150,7 @@ mixin AbortWhenNoInternet on ReduxAction { return await (Connectivity().checkConnectivity()); } + @mustCallSuper @override Future before() async { var result = await checkConnectivity(); From 30302318630fe9c07cc333e2e6bcf911b0050924 Mon Sep 17 00:00:00 2001 From: Andrzej Przedecki <108667553+aprzedecki@users.noreply.github.com> Date: Fri, 21 Jun 2024 10:25:57 +0200 Subject: [PATCH 2/2] added super calls --- lib/src/action_mixins.dart | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/src/action_mixins.dart b/lib/src/action_mixins.dart index f37a650..4ac19b9 100644 --- a/lib/src/action_mixins.dart +++ b/lib/src/action_mixins.dart @@ -76,6 +76,7 @@ mixin CheckInternet on ReduxAction { @mustCallSuper @override Future before() async { + super.before(); var result = await checkConnectivity(); if (result.contains(ConnectivityResult.none)) @@ -153,6 +154,7 @@ mixin AbortWhenNoInternet on ReduxAction { @mustCallSuper @override Future before() async { + super.before(); var result = await checkConnectivity(); if (result.contains(ConnectivityResult.none)) throw AbortDispatchException(); }