-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
review every command and possibility of user input #135
Comments
Now that users can ~BGinput color~RS, we should have a different care about everything that is user input. For now, this patch makes it so that: * descs with color do not ruin .who anymore * rank names with color do not ruin .who anymore * texts with color don't bleed out elsewhere There is probably plenty more where user-input color codes can mess up with current talker functionality: a thorough investigation of the use of color with each command should be done.
With us now saving places with colored names in them ( |
* We're now able to dig with places that have color right on the start of their names; * We no longer bleed color when trying to dig into a direction that already has something in there; * We're saving on the database the actual name with its ANSI colours, instead of the NUTS-style color codes. This is part of the efforts in #135 , even if it stays far from being solved.
This helps us with #135 - Nodiverse 0.4.0 letting us have a working .map even when the places shown in it start with a color.
|
issues detected on commands so far:
commands still not tested:
|
There might still be a problem with colored places - but this might also be because this map was made before the previous fixes (and I should make sure the nodiverse version being used here is also uptodate). Still, there's both a problem managing to go to the
|
...including MOTD and files, or other stuff that might not have been entered with commands, but certainly review every command too.
While we fixed #87 , allowing users to input color means we no longer control it - and, in particular, where it bleeds, or how to save it in the databases, or how to count the length of strings that might or might not have color... and so on.
It was quite easy to identify a few of this issues, and in eef1a39 I took care of those (and you can take a peek to understand the sort of issues I am talking about), but I'm pretty sure that if we do not review every little functionality from top to bottom with "color inputs and how they can mess things" in mind, we will most probably have still quite a few of those cases on our hands.
I'm tagging this as a "bug" because while I don't know any specific case where one actually exists... I bet there is more than one out there, related to this.
The text was updated successfully, but these errors were encountered: