Mapzen Place Picker not starting and throwing exception #449
Comments
|
Thank you for the detailed bug report. I'm unable to reproduce this using the places version and android API version given, could you provide a little more information? What does your dependency tree look like when you run |
|
Following is an output of executing Executing I am also pasting below my build.gradle from app module. Let me know if i am missing any dependencies. Or if it needs a different version of a library. Anyway, its not a such a big issue. If the place picker does not work. I am thinking of building my own place picker and directly using Mapzen Autocomplete API. I would be happy to share the code under open source if you want. PS : I have learned that if i use Google Places API in my android app i might require a commertial license which costs around 10000 $ annually. This is a huge amount considering the fact we require only geocoding api. Therefore we decided to look for alternatives and stumbled upon Mapzen geocoder. Mapzen geocoder appears to be a very good option because it is giving a good results. I have also tested photon geocoder at http://photon.komoot.de. but photon geocoder lacks ability to sort results by focus point. Even nominatim lacks this. But Mapzens Pelias geocoder works just fine with focus points. following is the dump of |
|
Great, thank you for all of this, it's very helpful! And now I know definitively what the issue is :) The crash is happening because of the way dependency conflicts are resolved in gradle. Your app depends on a newer version of dagger ( I've created an issue in our repo to upgrade to the latest version (#451) but in the meantime you will have to change the version you depend on to something compatible with 2.0 or handle the version conflict in some other way. |
|
Thanks for your help ... You were right ! The place picker looks good and loads faster than googles place picker. But you can improve it by allowing user to choose current location and pick a location by clicking on map. This app has a very good place picker you can checkout at this link Koomoot app playstore (Disclaimer : I have no association with this app) |
|
Great, I'm glad changing to 2.0 hasn't caused any conflicts in your app. Regarding:
This is possible with our place picker. You will need to set the bounds when starting the |
|
Ya ... i forgot to see ... picking a location by clicking on map is actually possible (i was unable to notice it previously i didnt saw it ) ... but its allowed only for well known places like hospitals and shopping malls. What if a user wants to pick a place (from the map) which is not a well known place ? Except for this everything else is just fine ... and good to go ! |
|
The data you see on the map comes from our vector tile service which relies on a few large and well respected sources, most notably OpenStreetmap. Within that set are lots of places which aren't "well known". Take a look at our documentation for more details on the types of "points of interest" we include. And if you have specific places which you know exist but that you don't see on the map, the best way to include them is to add them to OpenStreetmap (our tile service will pull in these regular updates so they can be displayed on the map). |
|
I agree ... what i was trying to say is a different issue ... i mean to say user should be able to pick any location on the map. Currently this is not the case. You can pick only those places (including not so well known places) which are marked by a special marker ... For example : i cannot choose my home from the map even if i click on it because it is not marked by a special marker ... other place pickers do allow users to pick just any location ... try clicking on the map ... you will get what i mean to say ... |
|
Thanks for the clarification. This is behavior we intend to add in the future but just haven't had time to do so yet. I created a ticket to track the work. At the moment, I can't say we will implement it but feel free to create a PR if you're up for it/need it soon (we love external contributions)! Otherwise, you can track progress in that issue. Thanks for your thorough investigation of the Places API! |
|
You are welcome ! Sure i would love to contribute ... if i happen to implement the feature ... personally i always prefer open source code over propritiery code / libraries ... and i really appreciate that you guys at mapzen have made lot of awesome projects completely open source ... so thanks for that ... |
Description
Hi, my android app currently uses Google Maps Place Picker which i want to replace with Mapzen Place Picker.I have followed the instructions given at this link : https://mapzen.com/documentation/android/places/#placepicker-ui
This tutorial tells that you can easily replace the google's place picker with mapzen picker.
but in my case the code is failing with an exception.
Be aware that The original code with Google Place Picker is working fine and not Crashing !
Stack Trace of the Exception
Steps to Reproduce
I have used the following code to launch mapzen place picker. The picker doesnt open and crash before showing anything.
Mapzen SDK & Android Version
I am using android api 26 as a compile version and following mapzen api as gradle dependency
compile 'com.mapzen:mapzen-places-api:1.3.1'
The text was updated successfully, but these errors were encountered: