Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task "Generate mailcow.conf file" does not behave declaratively #39

Open
jimboolio opened this issue Jan 2, 2023 · 0 comments
Open

Comments

@jimboolio
Copy link

In main.yml task Generate mailcow.conf file calls ./generate_config.sh but if that fails at any point, re-running the playbook does not rebuild mailcow.conf since that script checks if mailcow.conf is already installed so the config will be left broken and not as defined when calling.

Technically the playbook should respect the changes set when calling it and override the variables set in mailcow.conf, but that would also likely break stuff, so my suggest solution would be adding a check what the variables already exists and if they differ, then the playbook should probably exit with an error, since otherwise it will succeed and silently keep incorrect configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant