Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route Params aren't passed for vike #49

Open
4350pChris opened this issue Feb 10, 2024 · 4 comments
Open

Route Params aren't passed for vike #49

4350pChris opened this issue Feb 10, 2024 · 4 comments

Comments

@4350pChris
Copy link
Contributor

See https://test-vite-vercel-plugin.vercel.app/named/id-3 - the routeParams in the vike integration aren't passed to the client anymore. As far as I can see, this is because __original_path doesn't include them (anymore?). Howver, url (which is logged in the ssr handler) does include it - it would be the correct url if the encoded __original_path were missing. So, maybe the thing to do is to just remove it via regex and use url?

@4350pChris
Copy link
Contributor Author

4350pChris commented Feb 10, 2024

Actually, nevermind. I misread and thought the first line with this page is: is incomplete. However, I do have this exact problem with my integration and I have no ideas what causes this as the only thing I'm doing is adding the main plugin to my vite.config.ts and the vike integration into renderer/+config.h.ts so I'll leave this issue open.

Specifically, all the query related properties of pageContext.urlParsed are empty in all my route functions when using this plugin. I'm trying to switch to Vercel from an express server and for the express server everything works as it should.

@magne4000
Copy link
Owner

I opened an issue on Vercel side: vercel/vercel#11144

@4350pChris
Copy link
Contributor Author

Anything I could do to help? Still not working for me, which is a bummer. I can't deploy my app on vercel like this.

@magne4000
Copy link
Owner

@4350pChris You should probably directly contact Vercel support and their link this issue to describe your problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants