Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade React to v17 #13124

Closed
thmsschmitt opened this issue Jun 29, 2022 · 0 comments · Fixed by #13448
Closed

Upgrade React to v17 #13124

thmsschmitt opened this issue Jun 29, 2022 · 0 comments · Fixed by #13448
Assignees
@thmsschmitt
Labels
component: nms NMS-related issue

Comments

@thmsschmitt
Copy link
Contributor

thmsschmitt commented Jun 29, 2022 •
edited
Loading

Only upgrade to React 17 to unblock #13270 which in turn blocks upgrading to React 18.

The breaking changes are minimal https://reactjs.org/blog/2020/08/10/react-v17-rc.html#other-breaking-changes

If all our dependencies allow us to upgrade to React 18 needs to be evaluated at a later stage.
Material UI 5 should work with React 18 see mui/material-ui#32074 even-though the related milestone is not at 100% https://github.com/mui/material-ui/milestone/45.
This needs for instance to be resolved material-table-core/core#536

When upgrading to React 18 also upgrade to react-testing-library 13
@thmsschmitt thmsschmitt added the component: nms NMS-related issue label Jun 29, 2022
@thmsschmitt thmsschmitt changed the title Upgrade React Upgrade React to v17 Jul 21, 2022
@thmsschmitt thmsschmitt mentioned this issue Jul 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thmsschmitt thmsschmitt

Labels
component: nms NMS-related issue
Projects
No open projects
NMS
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(nms): Upgrade React to v17 thmsschmitt/magma
1 participant
@thmsschmitt