Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why protobuf >= 4.21.2? #67

Open
bluenote10 opened this issue Aug 5, 2022 · 3 comments
Open

Why protobuf >= 4.21.2? #67

bluenote10 opened this issue Aug 5, 2022 · 3 comments

Comments

@bluenote10
Copy link

Recently the dependency on protobuf has been bumped to >=4.21.2, but apparently without a related code change (at least not in the same commit). I'm wondering why this was necessary?

From what I can see this leads to massive problems with other libraries in the ecosystem. In particular:

  • tensorflow 2.9.1 itself has a dependency protobuf<3.20,>=3.9.2
  • tensorboard 2.9.1 has a dependency protobuf<3.20,>=3.9.2
  • tensorflowjs 3.19.0 has a dependency protobuf==3.20.0
  • tflite-support 0.4.1 has a dependency protobuf<4

Due to the note-seq's requirement of protobuf>=4.21.2 it basically becomes unusable in the tensorflow ecosystem. This doesn't seem to make sense, in particular if nothing obvious has changed in the code? Shouldn't it be much more liberal in the protobuf version to avoid this dependency hell?

@czflshzy
Copy link

I meet the same problem

@Liujingxiu23
Copy link

I meet the same problem when pip install.
how to fix the problem?

@kevinzakka
Copy link

Also having this issue, can this be reverted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants