Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary logs?? #6

Open
max1mde opened this issue Mar 12, 2024 · 6 comments
Open

Unnecessary logs?? #6

max1mde opened this issue Mar 12, 2024 · 6 comments

Comments

@max1mde
Copy link

max1mde commented Mar 12, 2024

Why is it getting logged if I view the page in the Browser?

image

@K0-RR
Copy link

K0-RR commented Mar 13, 2024

Because that's how it should work? Discord is a web browser…

@max1mde
Copy link
Author

max1mde commented Mar 13, 2024

But why is the requested page favicon.ico then? Like this could be filtered... This is only happening if I open the actual site in my browser (not on discord.com)

@RyfterWasTaken
Copy link

i fixed this in my PR #5

@lulu5239
Copy link
Owner

The favicon.ico page is automatically requested by browsers (when they search for an icon for the website). It lets you know when someone is opening the view-logger in a browser, it isn't that bad...

@RyfterWasTaken
Copy link

But it still triggers twice, and you just need to make it not trigger if the pathname is /favicon.ico

@max1mde
Copy link
Author

max1mde commented Mar 14, 2024

Yes also I dont want to know if the faveicon was requested... thats not the purpose of this. I just wanna know if a person requested a specific url not some random logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants