From 6b6c352fb07b977b3cbe8d6766c93ba697df5abe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Steve=20Fr=C3=A9cinaux?= Date: Thu, 5 Jan 2023 22:18:33 +0100 Subject: [PATCH] RonRonnement CSS: Fix small discontinuity in the left sidebar Commit 88aa3c387cd3c42d34b9b91c33d5a591a0b5bcdf included a small computation mistake: the border should be taken into account in the calculations. Also, while it looks correct in Chrome, for some reason Firefox does not properly position the linear gradient origin when the background is set to `repeat`. Funnily it doesn't exhibit the same behaviour when using the built-in screenshot tool. We add `no-repeat` to the background specification to fix this. We also remove the backgrond of the sidebar as it is useless since it is the same colour as the body background, but it makes the miscalculation obvious should one happen again. --- app/assets/stylesheets/parts/a_tag.scss | 7 ++++--- app/assets/stylesheets/parts/sidebar.scss | 1 - 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/assets/stylesheets/parts/a_tag.scss b/app/assets/stylesheets/parts/a_tag.scss index e7369af54..f0d96ddbd 100644 --- a/app/assets/stylesheets/parts/a_tag.scss +++ b/app/assets/stylesheets/parts/a_tag.scss @@ -22,11 +22,12 @@ body { margin: 0 auto; border: solid #999; border-width: 0 1px; - background: linear-gradient( + background: no-repeat + linear-gradient( 90deg, $C_CLAIR, - $C_CLAIR $PX_BRANDING_LARG, - $C_CONTAINER $PX_BRANDING_LARG, + $C_CLAIR $PX_BRANDING_LARG + 1px, + $C_CONTAINER $PX_BRANDING_LARG + 1px, $C_CONTAINER ) #fff; diff --git a/app/assets/stylesheets/parts/sidebar.scss b/app/assets/stylesheets/parts/sidebar.scss index d84a90e2a..49df9bfdd 100644 --- a/app/assets/stylesheets/parts/sidebar.scss +++ b/app/assets/stylesheets/parts/sidebar.scss @@ -4,7 +4,6 @@ text-align: left; font-size: 0.8em; line-height: 1.3; - background: $C_CLAIR; a { font-weight: inherit;