Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The shiv of release page should probably be generated on Windows #233

Open
akgnah opened this issue Jan 30, 2023 · 1 comment
Open

The shiv of release page should probably be generated on Windows #233

akgnah opened this issue Jan 30, 2023 · 1 comment

Comments

@akgnah
Copy link

akgnah commented Jan 30, 2023

I downloaded shiv v1.03 from the release page, and when I tried to run it, it didn't work as expected.

PS D:\> py -3.9 ./shiv -h
Traceback (most recent call last):
  File "D:\Program Files\Python39\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "D:\Program Files\Python39\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
.
.
.
  File "C:\Users\Toor\.shiv\shiv_1c0a7a05e4af1a79fd343dde784c153c0929af743f4412922
abd6ce5dbfb620d\site-packages\click\_compat.py", line 541, in auto_wrap_for_ansi
    import colorama
ModuleNotFoundError: No module named 'colorama'

According to the traceback message, I found that the click has additional dependencies on Windows.

It appears that the shiv was generated on Linux, so the builder did not install colorama.

Then I installed shiv from pip and generated a new shiv, and this time it worked fine.

There may be other users like me who have downloaded it and want to run it to see how it works.

So I think the shiv of the release page should be generated on Windows.

@lorencarvalho
Copy link
Contributor

hey @akgnah
thanks for the report! I don't have a windows machine handy to make the release, but I could spend the time to automate it via Actions

I'm not sure when I'll find the time, but I will leave this issue open until I do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants