Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auths of everything by owner #217

Open
sundy-li opened this issue Dec 12, 2019 · 2 comments
Open

Auths of everything by owner #217

sundy-li opened this issue Dec 12, 2019 · 2 comments

Comments

@sundy-li
Copy link

sundy-li commented Dec 12, 2019

I just create a issue #210 and fixed the ServiceList filter codes.

But I found that the ProjectList, RulesList (/rule), UrlsList, NotifiorsList will display all the entries by default.
It's not very safe because we have lots of users to manage different projects. We should ensure that each user could only have the update privilege of there own projects,rules, urls etc.

@kfdm
Copy link
Collaborator

kfdm commented Dec 12, 2019

Right, currently the recommended way to handle this, is a promgen instance per-team. In the future I would like to better handle groups but I'm trying to refactor some other parts of Promgen before I try to tackle groups

@sundy-li
Copy link
Author

Ok.

And I'd like to create some PR to improve promgen, but I found that there are many conflicts of code, it's hard to track different branches.

So I will create some issues later which may be fixed in my version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants