Avatars are not loading on the Home scene for certain locales

[Bardreamaster]

I'm running lexicon alpha-v2 locally and run app on iOS, with an WARN:

 WARN  Sending `onAnimatedValueUpdate` with no listeners registered.

At the same time, the avatars on main page is not available. But they are available after clicked into post page:

Others looks good.

[gabriellaputri]

Can you provide steps to reproduce the bug?

[Bardreamaster]

Yes, just run quickstart but change discourse site to point to:

1. Download repo, change quickstart site into mine which is forum.robook.org. Run npm install && npm run generate.
2. Run npm run quickstart.
3. Connect front app using ExpoGo on iphone with iOS version 16.6.
4. On expo, it can be observed that :
   • A warn message: WARN SendingonAnimatedValueUpdatewith no listeners registered.
   • The avatars on main page is not available. But they are available after clicked into post page.

[gabriellaputri]

I tried running the app and pointing it to your discourse site and noticed that the value for authorUserId in all posts is null. We use authorUserId to identify the author of the post and get the author's avatar. So that's why the image doesn't show up.

[Bardreamaster]

Got it. is there any configuration has influence on authorUserId ? Or which config would make it not null? My site is using the default config.

Thanks a lot!

[gabriellaputri]

After some digging, it appears that this issue is connected to how we retrieve the value for authorUserId. It's not directly returned from Discourse, but from our own endpoint.

t.nullable.int('authorUserId', {
   resolve: ({ posters }) => {
      const author = posters.find((p: Poster) =>
         p.description.toLowerCase().includes('original poster'),
      );

      return author?.userId || author?.user?.id || null;
   },
});

As you can see from the code snippet above, we determine the author by checking the user's description if it includes the phrase 'original poster'. Because the phrase is in English, it didn't match the user's description on your site which uses Chinese, resulting in a null return.

Thanks for pointing this out! We'll schedule a fix on our end. And of course, feel free to jump in with any contributions if you'd like.

[Bardreamaster]

Thanks so much!

[Bardreamaster]

@gabriellaputri I'd like to know the way of how to fix it gracefully (not just replace the phrase directly). I've checked that there are several i18n config files in discourse config in .yml includes these system keywords. It might be good if we search different content to get authorUserId for different language setting. But I've never used TypeScript before. So if you have some good idea to fix this problem from your professional view, I'll try to help to fix if I could.

[jovitazhang]

Hi @Bardreamaster, we actually need to investigate this first, since it might be a regression—it was previously working. We'll be looking into this tomorrow and ideally getting to a fix soon after. We'll keep you posted on what we've found. Thanks for your patience!

[gabriellaputri]

@Bardreamaster Just wanted to give you an update. We've fixed this issue in the latest push on the alpha-v2 branch. Feel free to test it out and let us know how it's going. If more issues arise or you have more thoughts to share, don't hesitate to reach out again. Your input is invaluable in improving our project!