Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for controllers #163

Open
mhubii opened this issue Mar 14, 2024 · 10 comments
Open

Add support for controllers #163

mhubii opened this issue Mar 14, 2024 · 10 comments

Comments

@mhubii
Copy link
Member

mhubii commented Mar 14, 2024

@mhubii mhubii mentioned this issue Mar 14, 2024
32 tasks
@CarlDegio
Copy link

Will end controller be updated soon?

@mhubii
Copy link
Member Author

mhubii commented Mar 25, 2024

you mean end-effector velocity? Yes, we should add support for MoveIt Servo etc

@CarlDegio
Copy link

Actually I am referring to the end position controller, but it can also be achieved with the end speed controller.

Also, I have tried moveit servo. It's not work well. It seems that its solving frequency cannot reach 100Hz so there are noise when running. And it will move to all joints zero when error in config files, dangerous. It broke my heart :(

@mhubii
Copy link
Member Author

mhubii commented Mar 25, 2024

well lets get that sorted then, I am quite positive this should work now. Moving the end-effector to a target position can be achieved in a variety of ways

@CarlDegio
Copy link

The Cartesian controllers mentioned here may work better. Especially I notice it has force controller and impedance controller, which only realized in kuka workbench (SmartServo) now.

@mhubii
Copy link
Member Author

mhubii commented Mar 25, 2024

jap, would be great to use an open-source version for Cartesian impedance control etc

@mhubii
Copy link
Member Author

mhubii commented Mar 25, 2024

by the way, if you would want to create a pull request for the moveit servo, I am more than happy to review it

@matthias-mayr
Copy link

FYI, we ran the cartesian_controllers package on an iiwa7 with iiwa_ros in ROS 1 some years ago, but the results were a bit mixed. It was fairly difficult to find a stable configuration and it came of the cost of slow and sluggish behavior. There is a master thesis report on that. But I know that Stefan did some updates on the package that could have changed that.

For us, we proceeded to implement real Cartesian impedance control and made it available on Github and also wrote a short paper. It's fairly easy to integrate. However unfortunately I did not have time to port it to ROS 2 yet and I will also not have time in the near future.
If anyone wants to do that, I am happy to answer questions and review the code.

@mhubii
Copy link
Member Author

mhubii commented Mar 25, 2024

hi @matthias-mayr , thank you for reaching out, been following your implementation, congrats on the PhD ! Would love to see what can be done re ROS 2 on your implementation. Let's see!

@matthias-mayr
Copy link

Thanks. There have already been requests for ROS 2 and there's an open issue. If one goes down the "easy" road like cartesian_controllers and has a separate branch it should be fairly straight forward. The base library that implements the algorithms is separated and just has a ROS wrapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants