Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Multiple administrator accounts #88

Open
emorchy opened this issue Feb 14, 2021 · 7 comments
Open

[Feature] Multiple administrator accounts #88

emorchy opened this issue Feb 14, 2021 · 7 comments

Comments

@emorchy
Copy link

emorchy commented Feb 14, 2021

I am loving this project and all its usefulness, and I wish to recommend a feature regarding administrator accounts. If a user wants to stop watching after they complete a movie or show, one would need to log into an admin account and stop watching from there. Unfortunately, I am unable to grant admin privileges to user accounts.
I believe this would be incredibly useful because multiple users can become administrators, giving the ability to stop watching shows. In addition, if multiple moderators collaborate on this tool without wanting to share the same credentials, multiple administrator accounts would be beneficial.
I wish to propose two possible options towards making this feature possible:

  1. A checkbox next to each user to select whether they have privileged access in the nefarious settings page.
  2. The less secure option would be to allow users to stop watching their own shows but still prevent access to the settings page. It would not create the feature of having multiple administrators, but it would give extra privileges to multiple user accounts.
@lardbit
Copy link
Owner

lardbit commented Feb 14, 2021

This is a good idea regarding the ability to add additional "admin" users. I will leave this open until I get the chance to add that feature.

However, you also found a bug. I intended for unprivileged users to be able to stop watching their own shows & movies, but it looks like it wasn't working for tv shows. I just fixed that and it should be releasing soon.

As a workaround for creating more admin users you can actually log into the "admin console" and add a user there.

Admin console: http://127.0.0.1:8000/admin/
User add: http://127.0.0.1:8000/admin/auth/user/add/

The passwords are more strict when adding from the admin console. Users added through nefarious will let you set any password.

After you add the user, you'll have to edit the user in the admin console to be staff status and superuser status.

@lardbit
Copy link
Owner

lardbit commented Feb 14, 2021

The ARM builds are currently failing and I think I remember you using that architecture, so it's not releasing my changes yet.

https://travis-ci.com/github/lardbit/nefarious/builds

I'm researching that issue but wanted to give you a heads up the bug fix isn't releasing for ARM right now.

@emorchy
Copy link
Author

emorchy commented Feb 14, 2021

Thank you so much for your quick response. I was previously unaware of the Django site administration for nefarious, and this helps significantly. I will keep my eye out for any more bugs in the future. Thank you again.

@lardbit
Copy link
Owner

lardbit commented Feb 16, 2021

@emorchy, I'm working on building docker images for different architectures. I know you're running a raspberry pi like me. Can you tell me which pi you're using and what the following command says?

uname -m

I'm trying to find out if I need to support 32 or 64 bit architectures.

@emorchy
Copy link
Author

emorchy commented Feb 16, 2021

Absolutely. My raspberry pi is a 3B+. It has a 32-bit architecture with an armv7l processor.
Output: armv7l

@lardbit
Copy link
Owner

lardbit commented Feb 16, 2021

Thanks. It surprised me that the pi's are 64 bits but run a 32 bit os. I'm using travis-ci to automatically build the docker images but they don't support 32-bit arm...so I'm going to start using Github Actions which apparently supports a lot more architectures.

@emorchy
Copy link
Author

emorchy commented Feb 16, 2021

I'm glad I could be of help. Please let me know if there is anything more I could do to further raspberry pi support to this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants