Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If null vectors are present than the non-CUDA path will include these in training #2911

Open
westonpace opened this issue Sep 18, 2024 · 0 comments

Comments

@westonpace
Copy link
Contributor

I recently added null filtering to the IVF & PQ training in the CUDA path in https://github.com/lancedb/lance/actions/runs/10930801434/job/30344492517?pr=2910

I was curious what our non-CUDA path did. It does not fail but I believe it is using whatever garbage values are in the null vectors as real values and thus, we are training on more-or-less random data. If the null percentage is fairly low then this isn't really a big deal but it might be something worth fixing at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant